Timi Wahalahti

I dug a little deeper to find out the possible cause for this.

It looks like the use of pre_get_document_title filter short-circuits the wp_get_document_title , which has filter document_title_separator.

That document_title_separator filter is used on feed-imporvements.php file to decode entities. But since the whole title generation is short-circuited, said filter is never used.

The following code, added to the theme, fixed it for now.

add_action( 'get_wp_title_rss', function( $title ) {
   return html_entity_decode( $title );
} );

I believe Yoast should do something similar in feed-imporvements.php instead of using document_title_separator filter.

Ran into the same issue. It seems to be happening because the title separator is outputted as an entity name (eg –) instead of entity number (&#8211) – at least in Custom Post Type feeds.

A similar issue was reported and fixed about two years ago.

Tested with the latest Yoast version, 19.14 and 19.13.

• This reply was modified 2 years, 2 months ago by Timi Wahalahti.

Thank you @coreyk for looking deeper into this and trying to solve the problem, even though you can’t reproduce it!

@coreyk Sorry I didn’t have time earlier today to really find out what happened in detail.

Tried to reproduce the issue as well a moment ago, in the very same site and environment, failing in it. Did do 1.8.5 -> 1.8.6 update via update-core.php and via ManageWP as well – everything went smoothly.

Some details that might or might not be helpful:
* WordPress Multisite
* Update was done via ManageWP
* Site uses Bedrock based stack, dudestack
* There is a cronjob in place that removes (wp-)content/cache/cache-enabler every fifteen minutes
* Another cronjob loops thru all the network sites and runs events due now

do you happen to be using any of the WordPress option hooks, such as pre_option_cache_enabler, filtering the Cache Enabler settings before being saved in the database?

Nope, no pre_option_* in use.

I can see few messages in the log that might be interesting/helpful. A useful little piece of information is the plugin update was done at 13:16.

What bugs me, is that we started seeing core related errors before there was anything CE related. Thought that might be because of the first error with timestamp 13:16:59 which looks like an infinite loop exhausted to me. Note the file_put_contents error there for one of the network sites setting file.

13:16:53 [error] PHP Fatal error:  Uncaught Error: Call to undefined function force_ssl_admin() in /var/www/redacted.fi/deploy/releases/20210215095505/wp/wp-login.php:15

13:16:55 [error] PHP Fatal error:  Uncaught Error: Call to undefined function send_origin_headers() in /var/www/redacted.fi/deploy/releases/20210215095505/wp/wp-admin/admin-ajax.php:25

13:16:55 [error] PHP Fatal error:  Uncaught Error: Call to undefined function wp() in /var/www/redacted.fi/deploy/releases/20210215095505/wp/wp-blog-header.php:16

13:16:59 [error] PHP Warning:  chmod(): No such file or directory in /var/www/redacted.fi/deploy/releases/20210215095505/wp/wp-admin/includes/class-wp-filesystem-direct.php on line 173PHP message: PHP Warning:  chmod(): No such file or directory in /var/www/redacted.fi/deploy/releases/20210215095505/wp/wp-admin/includes/class-wp-filesystem-direct.php on line 173PHP message: PHP Warning:  chmod(): No such file or directory in /var/www/redacted.fi/deploy/releases/20210215095505/wp/wp-admin/includes/class-wp-filesystem-direct.php on line 173PHP message: PHP Warning:  chmod(): No such file or directory in /var/www/redacted.fi/deploy/releases/20210215095505/wp/wp-admin/includes/class-wp-filesystem-direct.php on line 173PHP message: PHP Warning:  chmod(): No such file or directory in /var/www/redacted.fi/deploy/releases/20210215095505/wp/wp-admin/includes/class-wp-filesystem-direct.php on line 173PHP message: PHP Warning:  chmod(): No such file or directory in /var/www/redacted.fi/deploy/releases/20210215095505/wp/wp-admin/includes/class-wp-filesystem-direct.php on line 173PHP message: PHP Warning:  file_put_contents(/var/www/redacted.fi/deploy/releases/20210215095505/content/settings/cache-enabler/www.redacted.fi.network-website-slug.php): failed to open stream: No such file or directory in /var/www/redacted.fi/deploy/releases/20210215095505/content/plugins/cache-enabler/inc/cache_enabler_disk.class.php on line 430PHP message: PHP Warning:  chmod(): No such file or directory in /var/www/redacted.fi/deploy/releases/20210215095505/wp/wp-admin/includes/class-wp-filesystem-direct.php on line 173PHP message: PHP Warning:  chmod(): No such file or directory in /var/www/redacted.fi/deploy/releases/20210215095505/wp/wp-admin/includes/class-wp-filesystem-direct.php on line 173PHP message: PHP Warning:  chmod(): No such file or directory in /var/www/redacted.fi/deploy/releases/20210215095505/wp/wp-admin/includes/class-wp-filesystem-direct

13:16:59 [error] PHP Fatal error:  Allowed memory size of 536870912 bytes exhausted (tried to allocate 20480 bytes) in /var/www/redacted.fi/deploy/releases/20210215095505/content/plugins/query-monitor/classes/Backtrace.php on line 99PHP message: PHP Fatal error:  Allowed memory size of 536870912 bytes exhausted (tried to allocate 20480 bytes) in /var/www/redacted.fi/deploy/releases/20210215095505/wp/wp-includes/class-wp-fatal-error-handler.php on line 72PHP message: PHP Fatal error:  Allowed memory size of 536870912 bytes exhausted (tried to allocate 20480 bytes) in /var/www/redacted.fi/deploy/releases/20210215095505/wp/wp-includes/plugin.php on line 4475" while reading response header from upstream, client: 54.191.137.17, server: redacted.fi, request: "POST /wp-load.php?mwprid=<redacted> HTTP/1.1", upstream: "fastcgi://unix:/var/run/php/php7.4-fpm.redacted.fi.sock:", host: "redacted.fi", referrer: "https://redacted.fi/"

13:16:59 [error] PHP Fatal error:  Uncaught Error: Call to undefined function wp() in /var/www/redacted.fi/deploy/releases/20210215095505/wp/wp-blog-header.php:16

Here’s the Site Health Info.

### wp-core ###

version: 5.8.1
site_language: fi
user_language: fi
timezone: Europe/Helsinki
permalink: /ajankohtaista/%year%/%postname%/
https_status: true
multisite: true
user_registration: false
blog_public: 1
default_comment_status: closed
environment_type: production
user_count: 28
site_count: 9
network_count: 1
dotorg_communication: true

### wp-dropins (4) ###

advanced-cache.php: true
db.php: true
object-cache.php: true
sunrise.php: true

### wp-active-theme ###

name: <redacted (custom theme for client>
version: <redacted>
author: Digitoimisto Dude Oy
author_website: https://www.dude.fi
parent_theme: none
theme_features: core-block-patterns, align-wide, wp-block-styles, widgets-block-editor, editor-styles, editor-style, widgets, menus, automatic-feed-links, title-tag, post-thumbnails, html5
theme_path: /var/www/redacted.fi/deploy/releases/20210215095505/content/themes/redacted
auto_update: Poistettu k?yt?st?

### wp-mu-plugins (8) ###

0-air-helper-media-fix.php: author: Timi Wahalahti, version: (undefined)
10-try-mediafiles-last-chance.php: author: Timi Wahalahti, version: (undefined)
Bedrock Autoloader: version: 1.0.0, author: Roots
dashboard-widget-upkeep-reminder.php: author: Timi Wahalahti, version: (undefined)
ManageWP - Worker Loader: author: GoDaddy, version: (undefined)
network-main-site-url-fixer.php: author: (undefined), version: (undefined)
wp-cli-flush-rewrite-all-sites.php: author: Timi Wahalahti, version: (undefined)

### wp-plugins-active (30) ###

Advanced Custom Fields: Network posts select field: version: 1.0.2, author: Timi Wahalahti
Advanced Custom Fields: Relationship field from main site content: version: 1.0.0, author: Timi Wahalahti, Digitoimisto Dude
Advanced Custom Fields PRO: version: 5.10.2, author: Delicious Brains
Air helper: version: 2.11.1, author: Digitoimisto Dude Oy, Timi Wahalahti
Broken Link Checker: version: 1.11.16, author: WPMU DEV
Cache Enabler: version: 1.8.6, author: KeyCDN
Gravity Forms: version: 2.5.11, author: Gravity Forms
Hide SEO Bloat: version: 3.14.8, author: SO WP
ICS Calendar: version: 8.5.0, author: Room 34 Creative Services, LLC
Imagify: version: 1.10, author: WP Media
Koko Analytics: version: 1.0.28, author: ibericode
Mailgun: version: 1.7.9, author: Mailgun
ManageWP - Worker: version: 4.9.10, author: GoDaddy
Object Cache Pro: version: 1.13.3, author: Rhubarb Group
<redacted (small custom client-specific plugin>: version: 1.0, author: Digitoimisto Dude, Timi Wahalahti
Public Post Preview: version: 2.9.3, author: Dominik Schilling
Query Monitor: version: 3.7.1, author: John Blackbourn
Redirection: version: 5.1.3, author: John Godley
Relevanssi Premium: version: 2.15.3.1, author: Mikko Saari
Simple History: version: 2.42.0, author: P?r Thernstr?m
Simple Page Ordering: version: 2.3.4, author: Jake Goldman, 10up
CPT person: version: 1.0, author: Digitoimisto Dude Oy, Timi Wahalahti
CPT project: version: 1.0, author: Digitoimisto Dude Oy, Timi Wahalahti
CPT event: version: 1.0, author: Digitoimisto Dude Oy, Timi Wahalahti
WP Sanitize Accented Uploads: version: 1.2, author: Onni Hakala / Geniem Oy
WP Signups: version: 5.0.0, author: John James Jacoby
WP SmartCrop: version: 2.0.5, author: Bytes.co
WP Term Order: version: 1.0.0, author: John James Jacoby
<redacted (small custom client-specific plugin>: version: 0.1.0, author: Digitoimisto Dude, Timi Wahalagti
Yoast SEO: version: 17.2.1, author: Team Yoast

### wp-plugins-inactive (7) ###

Classic Editor: version: 1.6.2, author: WordPress Contributors
GAinWP Google Analytics Integration for WordPress: version: 5.4.6, author: IntelligenceWP
<redacted (small custom client-specific plugin>: version: 0.1.0, author: Timi Wahalahti, Digitoimisto Dude
CPT news: version: 1.0, author: Digitoimisto Dude Oy, Timi Wahalahti
CPT X: version: 1.0, author: Digitoimisto Dude Oy, Timi Wahalahti
CPT Y: version: 1.0, author: Digitoimisto Dude Oy, Timi Wahalahti
CPT Z: version: 1.0, author: Digitoimisto Dude Oy, Timi Wahalahti

Some details that should have no effect on anything are redacted from logs and health info.

• This reply was modified 3 years, 5 months ago by Timi Wahalahti.
• This reply was modified 3 years, 5 months ago by Timi Wahalahti.

This happened also to us when updating from 1.8.5 to 1.8.6.

Thanks for the prompt reply!

For now, I’ve fixed the performance issues mentioned just by unhooking those functionalities but that’s not ideal so looking forward to fixes on upcoming releases. Again, thanks – plugin is otherwise very nice!

I noticed also another thing that causes A LOT of slowness. It’s function wprss_change_publish_button_text that get’s called in gettext filter.

Using that filter, the plugin generates multiple hundreds of small database queries to get the current post type. Unregistering that hook reduces the database query time 65%.

Again, needless to say, that this has a huge performance impact. Please find another filter of way to do the same thing.