skoldin

Hi Thomas,

Any updates on this?

Hi Thomas,

Sure, he checked and confirmed that the issue exists on woo.duracelltomi.hu as well.

Ok, I suppose now I see why the links are opened in the same window after a delay. First, you are trying to catch the pressed ctrl with var ctrl_key_pressed = event.ctrlKey. However, this won’t work on Mac because they press cmd instead of ctrl so you need to check for Cmd. So, what is happening next as far as I understand:

// this is going to be false because it is not ctrl, _productpage won't be assigned
if ( ctrl_key_pressed ) {
 var _productpage = window.open( 'about:blank', '_blank' );
}

'eventCallback': function() {
if ( ctrl_key_pressed && _productpage ) { // false
  _productpage.location.href= productdata.data( 'gtm4wp_product_url' );
} else { // the url will open in the same tab
  document.location.href = productdata.data( 'gtm4wp_product_url' )
  }
},
'eventTimeout': 2000 // after 2000ms

In regards to iOS devices (iPad, iPhone), perhaps, window.location.href is not working and nothing is happening when we click a link. I did a quick research and it seems people do have troubles with assigning an URL with JS on iOS devices.

What do you think?

—

For some reason, my reply is gone after editing it so I resubmit.

Regards,
Igor

Hi Thomas,

I updated and received feedback that it is not working correctly when on mac on either chrome, firefox or safari when clicking on command and then click the products (i.e. there is a second or two delay and then it opens up in the current page instead of opening up a new one).

Can you please shed some light why it is needed to prevent the default links behavior and then emulate it? From my observation, the data is pushed to the datalayer variable just the same if we allow default behavior.

Regards,
Igor

The “dataLayer” part is an object in the global scope. It is not on a separate domain and the dataLayer contains exactly the same data when these functions are commented out, so default links handling is not preventing pushing the data to the dataLayer. So I wonder, what is the reason behind adding those functions, are they necessary and how can we fix this iOS issue?

Hi Thomas,

I performed more tests and had to hold this off. The reason is that while I expected the global $product variable to be always available when the $post is available (accordingly to WooCommerce documentation, global $product is set when the_post function is called, that is, at the same time as the global $post variable, from which you take the product ID), but it appears that is not always the case (sometimes $product contains just the name of the product but not the product object) and I am not sure why.

So your way although is not that straightforward but seems to be more robust. I will do some investigation why WooCommerce is not assigning product object to the $product global variable when I have time and update the topic if I find something interesting.

Regards,
Igor

Hi Thomas,

This code is from /integration/woocommerce.php

get_the_ID() won’t work outside the main loop anyway so if you can get the product ID this way, I assume, the global $product variable will be available as well.

Thanks for the Github link, I will prepare the pull request as soon as possible so that you can review the change I mean.

Regards,
Igor Skoldin

Hi loretpao,

If you want this date format to be displayed on the frontend on the pixproof galleries, here’s how I resolved it:

1. Copy /wp-content/plugins/pixproof/views/pixproof_metadata.php to your-theme/templates/pixproof_metadata.php
2. Add $newDate = date("d/m/Y", strtotime($event_date)); under if ( ! empty( $event_date ))
3. Replace <span><?php echo $event_date; ?></span> with <span><?php echo $newDate; ?></span>

Hope this helps!

Resolved by combining it with another plugin.

Hi dcooney,

Yes, I read some but missed those parts. That’s a shame.

Thanks for your reply

Anyone?

Hi Ron,

Wow, that was simple! ?? Thanks.

What about images URLs? Is there a simple way to fix it?

Hi John,

No, there is no particular need of being an explicit member of both parent and children categories. But it is a bit confusing behavior, especially that it is not observed on the second level of nesting (if we use the path Test -> a, or Test -> b, the full path will be displayed regardless of the alphabetical order and being a member of the parent “Test” taxonomy).

Thanks for your explanation.