Spectacula
Forum Replies Created
-
Forum: Plugins
In reply to: [Spots] Any plans to fix incompatible toolbar icon in 3.9?This should be working with Version 1.2.1.
Forum: Plugins
In reply to: [Spots] Conflict with Event Organiser?Unfortunately I can’t really help you with this as I don’t know the plug-in causing the problem. Also without more information about the nature of the problem I couldn’t even begin to guess as to what the cause would be.
There are so many plug-ins out there that every plug-in is bound to conflict in some way with another one.
Forum: Plugins
In reply to: [Spots] Insert spot button in editor doesn't work in 3.9The latest version (Version 1.2.1) should be solid, tested and working in 3.8 and 3.9. You may have old JS cached. Can you try logging in to your WordPress install from private or incognito browser session or flushing out your cache completely. It could also be a broken install, it is possible that the install didn’t replace all files so you may need to remove the plug-in completely and reinstall.
Forum: Plugins
In reply to: [Disqus Comment System] Disqus Missing argument 2 for wpdb::prepare()The above fix is almost right but needs to be %d not %s. %s will wrap the replacement in single quotes that’ll break the quotes the %s is inside of, %d on the other hand won’t use quotes and is the most appropriate for a comment ID anyway.
I’m using the same method for this as Automattic use for the P2 theme.
It should, when making ajax requests, die not long after the plugins_loaded action and never load the front end HTML. If I was writing this for a one off job that needed to work with thousands of concurrent user then in all likelihood I’d write it so that it didn’t load any part of WP when making ajax requests. However this is a generic plug-in and needs to work with other plug-ins and any changes they make to comments.I can’t recreate the scenario where polling frequency is saved on a post by post basis. Whenever I make a change in the discussion settings on every install of this I manage it changes for every post. It sounds like you may have something aggressively cashing the front end or you have something that is turning the output into static HTML.
I can’t get the same problems to show up for me. However what I would advise as a better course of action would be to disable my commenting stuff on the wp-touch theme. This will reduce load on mobile devices and leave you with a touch friendly version of comments, which mine in it’s default form is not. WpTouch has it’s own ajax commenting so you’d not be missing out on much.
Adding this to the top of the spec_commenting > _init method will kill spec_commenting when something intercepts the template filter.
if ( get_template( ) != get_option('template') ) return;
I’ve added the change to the trunk version of commenting.php which you can find here https://plugins.svn.www.ads-software.com/spectacula-threaded-comments/trunk/
That looks like another positioning bug much like the one before. I’ll give it a look on one of my dev installs and see if I can find the appropriate thing to fix it.
Cool. Thanks. I was going to take a look it this morning.
You can create your own styles for the plug-in and wipe out all the original styling if you need to. Just drop a comments.css file into your theme’s folder, then from the spec comments admin page select the theme styling from the drop down. You can also add your CSS the the plug-ins style folder. Be careful with that as it can get wiped out by an upgrade to the plugin, that folder is more for us to add new default themes to it for release. Our main site uses this plugin but looks nothing like the styles included with the plug-in. For e.g. https://interconnectit.com/2364/announcing-spots/
As to working with other plug-ins that do things to the comment form, that can only really be done if we drop compatibility with older WordPress and implement the newer comments form. This could also cause problems for people who’ve rolled their own styles, although we’d take care to keep the same mark-up things would still be prone to change.
There is a simple fix for this. Go to External Links Settings and untick the box marked “apply globally”, post and comment content will still be dealt with but it won’t try and do every link on the page.
Okay. It seems that the “external links” plug-in kills the normal JavaScript on threaded comments, even without my plug-in in place.
Just tried this plug-in on my dev environment with 2010 theme and just the external links plug-in. They still sort of work in the none JS way after throwing an error to the console. The problem shows itself more readily with my plug-in as there’s a load more javascript for it to break and I’m doing a fair few things to avoid page reloads.Just done a little more digging and it seems the problem comes about as a result of the “external links” plug-in changing the quotes in the anchor tag from single quote to double. That conflicts with the double quotes that WordPress uses in the reply link’s javascript effectively closing off the JavaScript before it has really finished.
So
onclick='return addComment.moveForm("comment-8", "8", "respond", "1346")'
becomesonclick="return addComment.moveForm("
with the rest of the code looking like more attributes to most browsers.I could strip off the WordPress onclick code and use my own method with relative easy by I’d suggest you contact the author of the external links plug-in and ask them to fix it as I’d only be masking someone else’s problem.
I’ll take a look at that plug-in and see if I can see what’s up.
Released 2.1.2 which should fix the problems you were having. Should show up in the plug-ins list in about 15 to 30 mins from now.
Ah, just found that because the textarea is hidden when the hidden measuring div is created it has a width of 0px. I’ll just change the width of the measuring box to match that of the textarea at the same time I do my measuring. Should do it.
Sorry didn’t get a chance to look at your site before, busy with work.
I’ve installed the fullscreen theme on my local dev environment and replicated the issue and I know what it is and probably how to fix it.
Something the theme is doing to pop the comments up in a separate box is confusing my code that uses a hidden div ( The div expands to match the text inside it ) off of the body to measure the size the text area needs to be. I can try a few things to make this work, I already have a few ideas but don’t hold your breath as I have a project to finish this weekend.