Tim Eckel

The problem was identified and version 1.92 should correct the problem. Let me know if there’s any problems. A positive review would be greatly appreciated! Thanks!

I can’t find your email, what was the message subject?

An admin doesn’t “need” minified HTML, but what’s the harm? Also, by having HTML minified for admins it allows you to easily test that it’s working correctly.

I’m just at a loss as to what the problem is with the admin HTML being minified. If it’s readability, simply turn it off for development or use browser development tools to review the source.

I worded it the way I did on purpose so my email address would not be exposed to spiders. I would appreciate it if you would modify your reply to remove my email address. I already know my email address, I don’t need you to tell me what it is.

Sure, send it to tim at leethost dot com.

That’s a JavaScript error an Minify HTML doesn’t include any JavaScript so the error is not directly from Minify HTML. However, the minification process in Minify HTML could be causing it.

I would need to view the HTML source of the page where you’re getting this error. If you could turn on Minify HTML, go to the contact page which gets the error, view source for the page and copy it. Then, post it here inside code tags so I can duplicate the page and see where the problem is.

Thanks!

This is tough to test further as I can’t duplicate it. It would appear to be some kind of theme conflict. The only way I could test this further would be to see the popup on your site. Maybe a dump of the entire page HTML while the popup is being displayed? Then, I could create a static page from it and possibly see it in action.

You must be using target="_blank" which is on the list to be deprecated and is considered bad UX practice. I never do that so the link opens in the same tab so it’s a non-issue. However, I know people are still incorrectly using target="_blank" (much to the dismay of their users). Using target="_blank" takes control away from the user to decide if they want to open in a new tab or not. Users know how to open something in a new tab, so they should decide. Also, using target="_blank" causes further confusion as the “back” button doesn’t work.

In any case, I made some modifications so it will work and it’s released in version 2.0. However, I would HIGHLY suggest not using target="_blank" as it’s very frustrating to your visitors.

• This reply was modified 8 years, 2 months ago by Tim Eckel.
• This reply was modified 8 years, 2 months ago by Tim Eckel.

Got it sorted out. The issue was that I only thought of making the link a text link, so that’s all I ever tested. When clicking on a text link vs. an image link, JavaScript deals with the target differently. For a text link, the target is the anchor tag, which has the href path. For an image that’s a link, the target is the image not the anchor tag. So, the code was never seeing the href as the target was the image not the anchor tag. Interesting actually.

In any case, the code now looks at not only the click target’s href but also the click target’s parent href. This is a long-winded way of saying that it’s fixed.

I’ll update Popup Modal to v1.9 which will address this issue.

Links work for text, not images. I never thought about using a large image like this because I would design a popup to be a mixture of text and images for better responsive design, user experience, and SEO value.

With that said, I’m not sure why the link doesn’t work when it’s an image but works just fine for a text link. When building the ability for links to work I only ever tested text links as that’s all I would ever use for a popup.

I’ll look at the code to see why only text links would be working. But, I’d also suggest making your popups mixed media and only having part of the popup be the link. Also, your image is way too large, it scrolls off the bottom of my screen, which is a typical 1920×1080 display. Using mixed media, it would be far more readable too as the text is also very hard to read as-is.

PS: Next time I’m in NYC I’ll be sure to check out the Cannibal Liquor House! Love the Pee-wee Herman cycling pics too!

• This reply was modified 8 years, 2 months ago by Tim Eckel.

You can include html inside code tags in a reply here. But, I see that you have the popup running on the mentioned site already. I’ll take a look, thanks!

• This reply was modified 8 years, 2 months ago by Tim Eckel.

I can’t duplicate it. That’s why I need the full HTML (with full paths to images) of your popup and all of the settings. That way, I can duplicate it 100%.

Have you tried using close buttons instead? Have you turned off the print function? The print function is designed so you can click anywhere to print. If you’re trying to print AND have a link, it may work, but I’d need the EXACT popup HTML and settings to see what you’re doing as when I do it it works just fine. Then again, I use mixed media HTML in popups where there’s formatted text and images, not just one giant image for the entire popup. I’m all about SEO value, so I never create images like that, always mixed media.

I’ll need your entire actual HTML for the popup and all of the popup options (maybe a screenshot of the options?). I need this to duplicate your problem as I’m not experiencing this at all. I can add an image with a link and when I click on it it goes to the link every time. No issues at all.

I also don’t totally understand what you’re trying to do. Do you want people to print the popup or go to a link? How would you both print and go to a link? I’m trying to understand what you’re trying to do and what exact settings you’re using.

If including images in your HTML, make sure to specify the complete URL including domain so I can duplicate your popup 100%.

What do you have set for the “Button Location” for the Popup Options? If you set it to “No Buttons” it may seem like you can’t click the link, but you can. If you set the “Button Location” to “Left”, “Center”, or “Right” it may be more obvious.

If you still can’t get things working, I would suggest you attach the HTML text source from your popup as well as the Popup Options you have set. That way I can duplicate your settings to and duplicate what you are experiencing.

Tim

Try creating a new popup modal and leave the settings as default. Enter some text and try the test button.

• This reply was modified 8 years, 2 months ago by Tim Eckel.