Forum Replies Created

Viewing 15 replies - 46 through 60 (of 222 total)
  • Plugin Author Tim Eckel

    (@teckel)

    To be clear, this isn’t a problem with this Minify HTML, it’s a potential CSRF issue with WordPress and *any* plugin. I’ve updated Minify HTML to (v2.1.1) to address the potential WordPress vulnerability issue. This should now be resolved.

    Plugin Author Tim Eckel

    (@teckel)

    No clue, sounds like a false positive warning. Contact WP Toolkit and ask why the following code would trigger that error:

    https://plugins.trac.www.ads-software.com/browser/minify-html-markup/trunk/minify-html.php

    That link is the entire code for Minify HTML, and it doesn’t do anything with CSRF. My guess is WP Toolkit is overzealous and is looking for a string which happens to also be in the Minify HTML plugin.

    Plugin Author Tim Eckel

    (@teckel)

    Also, Minify HTML already removes self-closing tags, there’s a setting to turn that on or off.

    Plugin Author Tim Eckel

    (@teckel)

    Sure is. No updates because I don’t have any issues with it.

    Plugin Author Tim Eckel

    (@teckel)

    Can I ask why this is “needed”? Or are you just saying you’d “like” to add those substitutions?

    To add these substitutions you’d need to change the plugin. There’s no exposed hooks to add your own.

    Plugin Author Tim Eckel

    (@teckel)

    Have you turned off every other option as well? I’ve never heard of a situation where turning off every option didn’t resolve the problem.

    But, if even after you turn off every option you’re still having a problem, there must me something wrong with the slider revolution plugin. You’ll need to either remove slider revolution or minify html. I’m not using slider revolution so I have no way of diagnosing why that plugin isn’t working for you.

    Plugin Author Tim Eckel

    (@teckel)

    Turning off the minify inline JavaScript option would no longer minify inline JavaScript, resolving your issue.

    Plugin Author Tim Eckel

    (@teckel)

    When there’s an incompatibility, the issue is always which piece is at fault. Sometimes, neither are at fault as well.

    In any case, I would bet that Minify HTML will work just find with Slider Revolution if you set the settings to be compatible. This is exactly why there’s settings for Minify HTML, so you can turn on/off settings for compatibility reasons.

    In the FAQ section for Minify HTML, it describes the following:

    Are there any settings for Minify HTML?

    Yes. Under the Settings menu in the admin console there’s a Minify HTML menu item which allows you to modify Minify HTML settings.

    Set all settings to “No” and then see if everything works. If so, try turning on each setting till Slider Revolution fails. Then you’ll know what’s causing Slider Revolution to fail. Just leave that setting off so Slider Revolution doesn’t fail. Once you know what’s causing Slider Revolution to fail, you could contact them and let them know how they could fix their plugin to be compatible with minification.

    Plugin Author Tim Eckel

    (@teckel)

    This would be fairly hard to diagnose without having a website setup like yours. In the code, the link that the Read More link is going to is:

    get_permalink( get_the_ID() )

    That would normally be the link to the article. My guess is one of these other plugins has altered the links to be something different. If you could figure out how these other plugins alter the link, you could replace the above code in the Read More Excerpt Link plugin to what the other plugin is expecting.

    Sorry, but that’s about the best advice I can give. Plugins can cause conflicts if they’re both altering the same information, which it appears is the case here.

    Plugin Author Tim Eckel

    (@teckel)

    What are your Minify HTML settings? Also, try turning all the settings off and see if there’s still a problem. If not, try turning each setting on to identify which setting is causing the problem. It’s very common for people to try turning on all settings to minify as much as possible. But, there are settings because there can be conflicts with other plugins or custom code. The options allow you to get the most minification without breaking anything.

    Let me know what you find.

    Plugin Author Tim Eckel

    (@teckel)

    Thanks for the review. I’ll update to confirm latest WP version compatibility. Updating for version compatibility is a constant task.

    Plugin Author Tim Eckel

    (@teckel)

    GTmetrix can give different results each time you run it. It can easily vary 2%-4% when not even making any changes. So this sounds like it’s well within the margin of error for GTmetrix.

    Plugin Author Tim Eckel

    (@teckel)

    Minify HTML tries to be the last thing to run. Basically, right before sending to the browser, Minify HTML runs to compress the content. So it’s designed to run after caching. But, it’s possible there could be a conflict with a certain caching plug-in I guess. I’ve run a few caching plug-ins without issue.

    Plugin Author Tim Eckel

    (@teckel)

    That’s just an injected JSON file. As it’s in a script, you can either disable JavaScript minification or disable removing relative links. Those features are designed specifically to address custom things like this.

    Plugin Author Tim Eckel

    (@teckel)

    I’ve never even heard of “structured data”. I’ve used breadcrumbs for a decade, never used structured data and never had a conflict.

Viewing 15 replies - 46 through 60 (of 222 total)