Texiwill

A pre-save filter would be very useful so that the database does not get inundated with what is considered bad email addresses. I can do this for registration, just not signing up for email subscription, at least not directly. I probably could hook the submit and do an ajax call but something built in would be very useful.

Hello,

You are correct it outputs defer=’defer’ however it incorrectly handles the quotes… If I use single quote it works fine, but I often use double quotes and you outputting single quote messes up HTML. It outputs like this:

src="url' defer='defer'"

That ends up being parsed incorrectly. The code needs to handle double and single quotes appropriately.

I incorrectly stated what should be done… but for me the fix was to change line 432 to use double quotes not single quotes… However, the real solution is to detecting the quote mechanism and use it for the defer.

Best regards,
Edward L. Haletky

Hello JS,

I saw that. Great for those who do not want to mess with a child theme. I took them out of the specific content I use within a child theme ages ago. Not much work and I needed a child theme other issues.

Actually, I modified the child theme as little as possible. Modifying the child theme saves on over all processing time. I really like a speedy theme.

Best regards,
Edward L. Haletky

Hello,

The role=”complementary” was left within all the sidebar elements.

I agree about the schema.org bits. I used to try to shoe horn it in and now just use JSON+LD. If you could remove that, then my child theme would be very clean!

Oh. In the searchform.php you also have a W3C error where a </input> is not needed. But since I replaced the searchform it no longer shows up.

Check out https://www.virtualizationpractice.com/ for how I use this theme.

Best regards,
Edward L. Haletky

Hello,

Here you go:

https://www.ads-software.com/plugins/wp-charts/

Best regards,
Edward L. Haletky

Hello,

Sorry cannot provide the link as it is an internal site.

There is more than enough information to duplicate. Install wp-charts, create a chart, try to print the chart.

One way to make this work was to create the page, hide a bunch of elements via javascript, then call the print dialog. Everything printed properly then. The problem print-o-matic has is that it opens a new window and the JS grabs the wrong window apparently for wp-charts.

Best regards,
Edward L. Haletky

Hello,

Actually, adding the after html as stated will cause the print dialog to NOT appear. So there is a problem with this plugin interacting with the wp-charts plugin. Remove and the dialog appears once more but the chart does not.

Thank-you,
Edward L. Haletky

Hello,

I tried adding jquery adding the following to the before html:

<script type='text/javascript' src='https://servername/wp-includes/js/jquery/jquery.js'></script>
<script type='text/javascript' src='https://servername/wp-content/plugins/wp-charts/js/Chart.min.js'></script>

and the following to the after html:
<script type='text/javascript' src='https://servername/wp-content/plugins/wp-charts/js/functions.js'></script>

But the document.ready function is not firing. So I also tried it as a window.onload, window.onfocus, and window.beforeprint with no luck. Any other ideas?

Thanks,
Edward L. Haletky

Actually, I was not talking about combining the projects but making them somewhat interoperable. Your going into the area of dropping emoji’s, fixing fonts, etc. Those are elements of aac-scoring. I do a few other things around CSS as well but that does not impact your plugin. Two plugins doing the same thing is not difficult to manage but if they do we should ensure they at least do not clobber each other.

— Edward

Hello,

No, 1.2.5 is working fine. However, I do not mind helping you debug the new PHP Minify. JUst let me know what you need me to do.

Just trying to help. ??

Edward

Please let me know what you need to debug this.

Thanks,
Edward

Hello @dbrownad,

You should only need to disable JS Minification not disable the entire plugin. CSS minification works great as does JS aggregation.

Best regards,
Texiwill

Hello,

Here is the patch to fix the PHP7.0 compatibility issues. THere are two files that need an update: exploit-scanner.php and hashes-3.7.2.php… With this patch exploit-scanner is PHP Compatible.

diff -rcb exploit-scanner/exploit-scanner.php exploit-scanner.upd/exploit-scanner.php
*** exploit-scanner/exploit-scanner.php 2016-09-18 10:07:46.593223943 -0500
--- exploit-scanner.upd/exploit-scanner.php     2016-09-26 10:24:05.341990484 -0500
***************
*** 957,964 ****

  if ( class_exists( 'Text_Diff_Renderer' ) ) :
  class ES_Text_Diff_Renderer extends Text_Diff_Renderer {
!       function ES_Text_Diff_Renderer() {
!               parent::Text_Diff_Renderer();
        }

        function _startBlock( $header ) {
--- 957,964 ----

  if ( class_exists( 'Text_Diff_Renderer' ) ) :
  class ES_Text_Diff_Renderer extends Text_Diff_Renderer {
!       function __construct() {
!               parent::__construct();
        }

        function _startBlock( $header ) {
diff -rcb exploit-scanner/hashes-3.7.2.php exploit-scanner.upd/hashes-3.7.2.php
*** exploit-scanner/hashes-3.7.2.php    2016-09-18 10:07:41.375853804 -0500
--- exploit-scanner.upd/hashes-3.7.2.php        2016-09-26 10:24:06.287057530 -0500
***************
*** 1,4 ****
! <?php^M
  $filehashes = array(^M
  'wp-settings.php' => 'b8b62fb7a9d829a3bcbda1f5181f02b9',^M
  'wp-cron.php' => '0210bf661bbbeb1fb262b5189885892a',^M
--- 1,4 ----
! <?php^M
  $filehashes = array(^M
  'wp-settings.php' => 'b8b62fb7a9d829a3bcbda1f5181f02b9',^M
  'wp-cron.php' => '0210bf661bbbeb1fb262b5189885892a',^M

Best regards,
Edward Haletky

I just reread the code and while these ‘errors’ do exist, they are really quite well protected from being ‘called’ when the function and directives no longer exist. So I would claim this is not an issue anymore. Ideally, the code could be removed outright but too many folks are not yet at PHP 7.0.

Close this as not an issue, just a reporting problem.

Hello,

Which is one reason an option to handle it appropriately would be great otherwise people will mistype the path, etc. It is the only javascript file that is core that needs this type of attention.

I.e.:

[ ] Do nothing to Jquery (Leave in place and untouched)

Then it is up to others on how to handle deferment or not.

Best regards,
Edward L. Haletky