tezalsec

Hi @joostvandevijver , thanks for the clarification.

I would like to make the argument though that the order number that is communicated to the transactions overview in the Mollie account, is important enough as a central data element, that it should not be dependant on descriptions or translation files. Maybe its an idea that the order number deserves its own database entry in your Mollie databases, and not make its existence solely depend on a description field.

Regards.

Ok, I did the diff right away and applied it in 1.3.2.1, and your bit of code in class-mailtpl.php works, it does not do double theming anymore when resending. ??

But I see you did not use the “check attribute” method but just disabled it on specifically the plugin page of the mailcatcher plugin, which doesn’t make your solution very generic. Like the other plugin’s author said: this will occur on all email plugins resending emails.

Again, appreciate the hotfix. Thanks.

Regards,
Tez

Hi, appreciate the speed of tackling this, but unfortunately I can not test your plugin.

Some time ago I had the plugin rolled back and frozen at version 1.3.2.1, after updates giving issues because of your WC implementation, including your email template interface not being visible in the Customizer (I am using WP+Astra theme, in Chrome browser). I just tried to visit it in the customizer again, and the Email templates tab is visible for one second, then it disappears.. some js conflict probably. So I am rolling back and freezing again.

I loved the little plugin this was up to 1.3.2.1, but apparently you have big plans with it, making it bigger and versatile, and a little less stable it seems, but way beyond my needs.

I am not gonna test this further for now, too bad it means I can’t fix the double theming issue now. Maybe i’ll do a diff on your code someday, and apply the hotfix myself on the older version.

Thanks.

• This reply was modified 2 years, 1 month ago by tezalsec.

Thanks for your response at github, good idea about the attribute check, I created a ticket on their support page:
https://www.ads-software.com/support/topic/double-template-when-resending-with-other-plugin/

It’s just to bundle associated subjects together, like you do with other speed improvements within this plugin, and not having to expand in the number of plugins, that’s all. ??

You have a great day as well!

• This reply was modified 2 years, 1 month ago by tezalsec.

Thanks a lot again, @giuse ! You are right, and I could/should have figured that out myself. Just activating the mainwp child plugin on the homepage was enough to get it working again. I didn’t even have to add the backend URL and frontend URL as you suggested.

Why it worked before and then not anymore in relation to your plugin, is unclear to me, maybe what you said about the $_POST.

On another note, I just stumbled on your plugin https://www.ads-software.com/plugins/editor-cleanup-for-elementor/ , and will give it a try, the elementor editor slowness is quite bothersome, and I have often needed to increase the php memory limit just to load that. Any chance that plugin will be a part of your main plugin in the future?

Thanks again for your helpful and professional support.

Tez

Hi @giuse ,

so I doublechecked, I can confirm it is your plugin that causes it, but the issue started earlier, in version 1.9.3.6

I rolled back step by step from to 19.4.0 to 1.9.3.5 , I hope I have not corrupted any database data related to your plugin by this rolling back. I did do my large configuration of your plugin way before 1.9.3.5.
Have there been any infrastructural changes in the way your plugins uses tables or entries between these versions, or is it all just code enhancements?

I will stay for now at 1.9.3.5, I hope you come up with a solution. Version 1.9.3.6 is probably conflicting on entry with the plugin https://www.ads-software.com/plugins/mainwp-child/ somehow.

Thanks again for your great plugin and the love you put in.

Regards,
Tez

• This reply was modified 2 years, 2 months ago by tezalsec.

Ok, I saw other tickets reporting the same, and I was wrong about Chrome doing it wrong also. The issue is strictly related to Firefox and seems to be a known issue.

Unfortunately I already stepped over to another event plugin (not for this reason), deleted the remote plugin and have no local version of it, so I can not deliver that info anymore.

Hi Bojan, thank you. I did what you suggested, and it triggered the emails being sent again. ??

I then started eliminating possible causes to find the cause but could not really find any. The cause was not other plugins, and eventually I changed the frequency from twelve back to twice a day, and turned off your filter function, and it is still working.

So the cause is not clear, but it is working again.

Thanks again.

Regards, Tez

Hi @bojankatusic ,

all other emails are sent as usual.
They were no changes in the site at all at that time.
Nothing changed on the server, which is a VPS I myself manage.
There are no relevant error logs.

I just deactivated all non-essential plugins to see if that will make a difference, but I don’t think it will.

By the way, is there any option to trigger the daily digest email function, through interface or code? So I can try and debug what happens instead of waiting for cron?

Regards, Tez

Hi, I am a developer too and I am aware of the workings of the WP updating process, and have never experienced the frozen screen before. I never do local updating, so that is not it. Also, other plugins updates never freeze.

I am 99% sure it is a code issue, but I am not sure the cause is in your code. It could be in another plugin specifically interfering with yours, or it could be just code conflicting between plugins, that are neither erroneous, but just not playing well together.

Maybe I’ll investigate further someday, for now it does not have enough priority for me to spend time on.

Cheers.

• This reply was modified 2 years, 6 months ago by tezalsec.

Hi again,

although the JS deferring issue is resolved, the original issue of this thread remains unresolved.

The update screen still gets frozen when trying to update, now in the newest version as well. It could be a local issue, but I have never experienced this issue before with any plugin of mix of plugins. There are also no log errors.

The only way it succeeds is by downloading the plugin and then upload from my local computer..

PS. are you aware your page ‘https://themebeez.com/plugins/simple-gdpr-cookie-compliance’ does not exist anymore? Are you ending support for the plugin?

• This reply was modified 2 years, 6 months ago by tezalsec.

Hi again,

I investigated some more, and your mentioning of the file ‘simple-gdpr-cookie-compliance-public.js’ led to me exclude this file in the plugin Autoptimize. This is not excluding from caching, but excluding from optimizing, combining and deferring js files, and that seems to be the solution. ??

Since so many people use the plugin Autoptimize, maybe it is an idea to suggest in your documentation to exclude this js file in that plugin’s settings if people use that plugin or any other js optimization plugin.

Thank you for your help.

• This reply was modified 2 years, 6 months ago by tezalsec.

Hi,

have you tested it yourself with WP Supercache plugin?
I can not find any setting where I can exclude specific files. I can exclude only urls and cookies.

Regards.