Tharkon

Hi,

Is there any indication when in the future the plugin will make it simpler?
I am asking because I think it would also resolve this issue:
https://www.ads-software.com/support/topic/redirect-not-working-with-parameter-fbclid-from-facebook

We have thousands of redirects and are weighing the decission if we should wait for the plug-in to update or to manually change all the redirects to be regular expressions.

We have not yet moved to WordPress 5.0 since we are a bit wary about the changes to the editor. We are afraid of losing access to the html editor and being stuck with the visual editor which has numerous problems. Will try once we move over though, which should be soon after trying the plug-in to keep the old editor.

Awesome, thanks.

I just needed to change the name of the folder multi-rating-pro to multi-rating and that worked.

I noticed there has been an update since I last posted but the fix was not included.

Any news on when this will be fixed?

It is a simple typo, and I pointed out the exact files and line numbers where the fix should be applied, the total amount of work to fix it is by now probably an order of magnitude less than the time it took people have spent on this forum topic.

• This reply was modified 6 years, 8 months ago by Tharkon.

I am very disappointed that an error as simple as a typo is allowed to cause such serious problems for such a long time even though a step-by-step instruction for the fix has been provided already. I have just been reapplying the fix myself after every update but this should not be necessary.

I am aware that the customizations will be overwritten the next time that the plug-in updates. This is the main reason I have posted this topic so the typo can be fixed in that update.

I am not trying to modify a template within Popup Maker, I was not even aware that Popup Maker had templates. And your suggestion of adding a shortcode to the content of a popup in the editor has nothing to do with the problem I brought to attention.

I think I found the underlying issue in this line in the Popup.php class.
98: $this->get_meta( 'popup_title' );

get_meta will return an array if a post has multiple values with the same key.
How exactly a pop-up ends up with multiple popup_titles I don’t know, but since multiple people are having the issue it might be worth safeguarding against this possibility.

For my own sites I will resolve it for now by removing any extraneous popup_title values.

The effective part of Visual Term Description Editor in this case is the following line.
add_filter( 'term_description', 'do_shortcode' );

This filter does not work however because it is never being applied.
I fixed the issue myself for my installation by editing the following lines:

In /classes/class-perfect-woocommerce-brands.php
line 917: echo do_shortcode($queried_object->description);

In /classes/class-pwb-product-tab.php
line 45: <?php if( !empty($brand->description) ) echo '<div>'.do_shortcode($brand->description).'</div>';?>

However, this only lasts until the plug-in gets updated.
A more permanent solution would be:

In /classes/class-perfect-woocommerce-brands.php
line 917: echo apply_filters('pwb-brand_description',$queried_object->description);

In /classes/class-pwb-product-tab.php
line 45: <?php if( !empty($brand->description) ) echo '<div>'. apply_filters('pwb-brand_description',$brand->description).'</div>';?>

In functions.php

/* Allow shortcodes in brand pages */
add_filter( 'pwb-brand_description', 'do_shortcode' );

Adding the following code to line 89 would fix the issue until the plug-in gets updated:

$args['input_value'] = $args['input_value'] > $minQty ? $args['input_value'] : $minQty;

What I did, which remains after an update, was add the following to functions.php.

add_filter( 'amp_content_sanitizers', 'remove_AMP_Blacklist_Sanitizer', 10, 2 );

function remove_AMP_Blacklist_Sanitizer( $sanitizer_classes, $post ) {
	  unset($sanitizer_classes[ 'AMP_Blacklist_Sanitizer' ]);
	return $sanitizer_classes;
}

But that might be a bit overkill, since it doesn’t just allow forms, it allows everything. I hadn’t noticed the list you mentioned, I might have to play around with that, but there might not be a hook that deep into the class.

• This reply was modified 7 years, 7 months ago by Tharkon.

The first form is generated by a custom built plug-in. When that is filled out, a second form built with Gravity forms is displayed.

I also created a test page here:
https://www.verbouwkosten.com/test20170718/amp/

This includes the form code copied directly from ampbyexample.com.

As you might be able to tell, the form that appears on the regular page is missing on the AMP. And the AMP also has links to related pages that the regular page does not have.

This is an example url that is currently live.
https://www.verbouwkosten.com/kunststof-kozijnen/vergelijk-nl/

And this is the AMP version:
https://www.verbouwkosten.com/kunststof-kozijnen/vergelijk-nl/amp/

I added the script to the head as well but it seems that AMP strips out the form tags before that script even has a chance to validate them.

We want the count on both versions though.
Because we want to keep the accumulated count for existing posts which have been shared as HTTP but also acquire new shares on new posts which are shared as HTTPS.

I’m also looking for a way to make it easier to keep these changes when the plug-in is updated. In case anyone knows of any way to do that, I’d be happy to hear about it.