theMikeD

I’m glad it’s working for you. Two years is a long time in WordPress land and I’m hoping the developer can chime in with compatibility notes as well.

Closing.

Also note that the notice being generated has no effect on the functionality of the plugin. If for whatever reason the ‘cb’ column is not found, things just carry on.

I can’t duplicate the issue here.

The index this message is referring to (‘cb’) is the one used to identify the checkbox column in the term list. It is core WordPress. This array looks like this, code-wise:

[28-Mar-2017 23:10:47 UTC] Array
(
    [cb] => <input type="checkbox" />
    [name] => Name
    [description] => Description
    [slug] => Slug
    [posts] => Count
)

If you are seeing this message, the ‘cb’ column has been removed by another plugin or setting somewhere in a theme.

Please try again, with only this plugin and the twentyseventeen theme active and see if you have the same results. If you do, please edit the file referenced on line 244 to add the following:

error_log( print_r($columns, true));

Then revisit the steps to generate the error and check your log to see the contents of the array, and copy them into this thread.

This was an authentication problem. Adding –user=<name of valid user> solved it.

You can.

https://github.com/woocommerce/woocommerce/wiki/WC-CLI-Overview

Looks like you just posted your mail password to the entire internet. You should change that right away.

Sure. And like all plugin authors, you are prompted to test and confirm your plugin with current releases, and if it’s compatible to push the “Compatible up to” tag. That is what I’m asking about.

I’m not looking to contribute or take it over, I don’t have a specific issue, and I’m not looking to do basic QA acceptance testing. I’m looking for confirmation that you are ensuring compatibility with current versions before I use it. The repo is rife with abandoned plugins and I avoid them if possible. No offence is intended, I simply seek clarity.

In the case of this plugin, the stated compatibility is for version 3.8.15, which is a security fix for the 3.8 branch despite having been lapped by 3.9 over a year ago. Since you are stating that it is explicitly compatible with the updated 3.8 branch and not the 3.9+ versions released before 3.8.15 — and specifically the current version — it implies that you are only ensuring compatibility up to 3.8. Which is either accidental or very specific.

Hence my question.

First of all, a big thank you to Kelly for letting me make a copy of her site so I could diagnose this issue.

Kelly:

First, the reason why your first link doesn’t show images and the second does is because the first is a list of sub-categories and the second is a list of posts. So they use different code.

Second, this is not a problem with the plugin. It’s a problem with the code being used in your custom category.php to pull the image from the database. You can read about it here:

https://www.studiopress.com/important-announcement-for-genesis-plugin-developers

but the short version is that as of genesis 2.3.0, $term->meta is no longer populated. This line is causing the problem:

$image = isset($term->meta['term_thumbnail_id']) ? wp_get_attachment_image($term->meta['term_thumbnail_id']) : '<img src="/wp-content/plugins/genesis-taxonomy-images/assets/images/placeholder.png" />';

So you’ll need to get that fixed by whoever wrote the custom code for you, if it’s not you that wrote it. You can either do it directly or by using the function called gtaxi_get_taxonomy_image() which is in the plugin for just this purpose.

?? That means I need to see the files your theme is using to create the page that is showing both the correct images and the incorrect images.

I suspect it has to do more with genesis and WP than it does with this plugin…the change the update requires is to address the change Genesis made in how it gets and saves term meta.

Because I can’t duplicate this problem on the sites I manage, I can’t see it failing. And until i do I can’t figure out the nature of the problem. The only way for me to see it fail is to have admin+ft access to a site it’s failing on. So I’m hoping you’ll be OK with me poking around your site to fix this.

I’ll email you shortly.

I can’t duplicate this, and until I can I can’t fix it ?? Can you put the template used to generate both pages somewhere so I can see it please?

The old version of the plugin is available, but it requires the older version of genesis as well (prior to 2.3.0)

The code that pulls the images from the database is using wp_get_attachment_image() to do so. If the image is present, it’ll return the image and if it’s not it’ll return nothing. In your case it’s returning only the site URL, which tells me that it may be due to a config error or something with your specific site, as I can’t reproduce this on any of the sites I manage.

Please paste the code being used to generate the section of that page that is showing the wrong link.

At this point I’m not clear on what problem you’re seeing. The fixes I made are to ensure images show up in the admin area. Is that what you’re talking about? Please be as specific as you can be.

I’ve just pushed v1.1.1 When you see it as an update, install it and see if that fixes your problem.

Just a sec, I think I see the issue.