Nicholas Griffin

Thanks, it took me a while, but I have figured out a way of doing this, might make for a good post somewhere as I reckon some might like to do this.

Basically, I just added a function to the preview page that updates the advanced custom field, currently, mine gets a value from another field on the post a job page and pushes that to ACF, this allows me to conjoin the two ways that I am posting jobs.

Here’s the function:

<?php
$post_id = $form->get_job_id();
$values = get_post_meta( get_the_ID());
foreach($values as $key=>$val){
  foreach($val as $vals){
	   if ($key == '_postingtype_paj') {
		update_post_meta($post_id, 'postingtype', $vals );
		echo the_field('postingtype');
	   }
   }
 }

?>

• This reply was modified 6 years, 6 months ago by Nicholas Griffin.

On everything but the add post screen….

I am still getting them there and frankly it’s annoying, it also shows how poorly coded the addition is if it is showing in pages other than your own, to be honest.

I’ve simply disabled the plugin and I’m waiting for a fix, if any.

If there is any CSS, such as an inline style tag then it will not validate no.

You can check by copying your link here:

https://validator.ampproject.org/

If you can’t do that, right click on Chrome and click ‘Inspect’, then click on the console tab and it will show validation there too.

It’s not my plugin, I was just saying that they shouldn’t be shown to public users anyway, so shouldn’t really matter.

There’s a reason it omits style=”display:none;” and that’s because it’s not valid AMP HTML, with that code your AMP pages will not validate with Google as you can only set one set of styles with AMP.

So your only option is to add the style in the custom style screen of the plugin or to just simply put up with it.

Have you checked to see if these are shown to a public user? They seem like tags that will only be shown if the admin is logged in.

Try viewing a post when you’re not logged in or via incognito mode, see if they still show.

If you can’t then create a subscriber account and log in with that.

Well it doesn’t load HTTPS assets on the dashboard because of errors like this:

angular.min.js:29 Mixed Content: The page at ‘wp-admin/post.php?post=77929&action=edit’ was loaded over HTTPS, but requested an insecure image ‘https://www.google.com/s2/favicons?domain={{data.domain}}’. This content should also be served over HTTPS.

v 3.0.1.8 is still causing the site to crash for me.

Edit: Sorry I was still on 17, didn’t notice. Ignore me.

• This reply was modified 8 years, 3 months ago by Nicholas Griffin.

Hey,

I was just wondering if you managed to do this yourself as I am looking for a solution to this currently.

Just to expand upon this, I also used the PHP Compatibility Plugin and I am getting the following errors:

FILE: /opt/bitnami/apps/wordpress/htdocs/wp-content/plugins/amazon-web-services/vendor/aws/Guzzle/Service/Resource/CompositeResourceIteratorFactory.php
-------------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------------------------------------------------------
 3 | ERROR | 'resource' is a reserved keyword as of PHP version 7.0 and cannot be used to name a class, interface or trait or as part of a namespace (T_NAMESPACE)
-------------------------------------------------------------------------------------------------------------------------------------------------------------------

FILE: /opt/bitnami/apps/wordpress/htdocs/wp-content/plugins/amazon-web-services/vendor/aws/Guzzle/Service/Resource/ResourceIteratorClassFactory.php
-------------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------------------------------------------------------
 3 | ERROR | 'resource' is a reserved keyword as of PHP version 7.0 and cannot be used to name a class, interface or trait or as part of a namespace (T_NAMESPACE)
-------------------------------------------------------------------------------------------------------------------------------------------------------------------

FILE: /opt/bitnami/apps/wordpress/htdocs/wp-content/plugins/amazon-web-services/vendor/aws/Guzzle/Service/Resource/Model.php
-------------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------------------------------------------------------
 3 | ERROR | 'resource' is a reserved keyword as of PHP version 7.0 and cannot be used to name a class, interface or trait or as part of a namespace (T_NAMESPACE)
-------------------------------------------------------------------------------------------------------------------------------------------------------------------

FILE: /opt/bitnami/apps/wordpress/htdocs/wp-content/plugins/amazon-web-services/vendor/aws/Guzzle/Service/Resource/ResourceIterator.php
-------------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------------------------------------------------------
 3 | ERROR | 'resource' is a reserved keyword as of PHP version 7.0 and cannot be used to name a class, interface or trait or as part of a namespace (T_NAMESPACE)
-------------------------------------------------------------------------------------------------------------------------------------------------------------------

FILE: /opt/bitnami/apps/wordpress/htdocs/wp-content/plugins/amazon-web-services/vendor/aws/Guzzle/Service/Resource/ResourceIteratorFactoryInterface.php
-------------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------------------------------------------------------
 3 | ERROR | 'resource' is a reserved keyword as of PHP version 7.0 and cannot be used to name a class, interface or trait or as part of a namespace (T_NAMESPACE)
-------------------------------------------------------------------------------------------------------------------------------------------------------------------

FILE: /opt/bitnami/apps/wordpress/htdocs/wp-content/plugins/amazon-web-services/vendor/aws/Guzzle/Service/Resource/ResourceIteratorApplyBatched.php
-------------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------------------------------------------------------
 3 | ERROR | 'resource' is a reserved keyword as of PHP version 7.0 and cannot be used to name a class, interface or trait or as part of a namespace (T_NAMESPACE)
-------------------------------------------------------------------------------------------------------------------------------------------------------------------

FILE: /opt/bitnami/apps/wordpress/htdocs/wp-content/plugins/amazon-web-services/vendor/aws/Guzzle/Service/Resource/ResourceIteratorInterface.php
-------------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------------------------------------------------------
 3 | ERROR | 'resource' is a reserved keyword as of PHP version 7.0 and cannot be used to name a class, interface or trait or as part of a namespace (T_NAMESPACE)
-------------------------------------------------------------------------------------------------------------------------------------------------------------------

FILE: /opt/bitnami/apps/wordpress/htdocs/wp-content/plugins/amazon-web-services/vendor/aws/Guzzle/Service/Resource/AbstractResourceIteratorFactory.php
-------------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------------------------------------------------------
 3 | ERROR | 'resource' is a reserved keyword as of PHP version 7.0 and cannot be used to name a class, interface or trait or as part of a namespace (T_NAMESPACE)
-------------------------------------------------------------------------------------------------------------------------------------------------------------------

FILE: /opt/bitnami/apps/wordpress/htdocs/wp-content/plugins/amazon-web-services/vendor/aws/Guzzle/Service/Resource/MapResourceIteratorFactory.php
-------------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------------------------------------------------------
 3 | ERROR | 'resource' is a reserved keyword as of PHP version 7.0 and cannot be used to name a class, interface or trait or as part of a namespace (T_NAMESPACE)
-------------------------------------------------------------------------------------------------------------------------------------------------------------------

FILE: /opt/bitnami/apps/wordpress/htdocs/wp-content/plugins/amazon-web-services/view/footer.php
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
 1 | WARNING | No PHP code was found in this file and short open tags are not allowed by this install of PHP. This file may be using short open tags but PHP does not allow them.
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------

@nextscripts Glad to see that it has been fixed, thanks for the code so quick.

I’m getting the same, the plugin obviously has some bad code.

Hey,

I can confirm this is an issue, I just noticed it myself.

It seems that Facebook amp share requires an app ID to be set, and this AMP plugin does not allow for that.

I have pushed your topic to a Github issue, and I have already submitted a pull request that fixes the problem, if you know a bit about coding, then you could fix the problem for yourself there now.

Here’s the Github issue:

https://github.com/ahmedkaludi/Accelerated-Mobile-Pages/issues/107

Well it would need to disallowed in either the AMP plugin or the Facebook one, the author of this plugin has done something similar before, so it would require doing something similar to that, however, you would have to wait for an update.

Awesome, glad you fixed it. Also I’m pretty sure it is your Facebook commenting plugin yes.

Hey,

I don’t actually think that they are. They have been inlined and they belong to the mash share plugin that you have. These are the offending tags:

.mashsb-count{display:block!important;}}

@media only screen and (max-width: 568px) and (min-width: 480px) {.mashsb-buttons a{height:17px!important;}}

.mashsb-buttons a{text-decoration:none!important;}

@media only screen and (max-width: 460px) and (min-width: 100px){.mashsb-buttons a{min-width:20px!important;width:41px!important;height:20px!important;}}

@media only screen and (max-width: 460px) and (min-width: 100px){.mashsb-buttons a{min-width:20px!important;width:41px!important;height:20px!important;}}

@media only screen and (max-width: 460px) and (min-width: 100px){.mashsb-buttons a{min-width:20px!important;width:41px!important;height:20px!important;}}

If you don’t remove these !important tags then AMP won’t validate.