Shane Gowland

Hi Kuba,

That’s great news! (well, not the bug, but that you spotted it)

I’m happy to pull the new file from GitHub when you have it ready, just give me a heads-up in this thread.

Thanks for your help ??

Kind regards,

Shane

As far as I can tell, they’ve just been created with Capability Manager Enhanced.

No plugins reference the pending customer role. The only place I can see it used is in the theme—there’s a helper function in functions.php

function is_user_pending_customer($user) {

    if ( isset( $user->roles[0] ) && $user->roles[0] == 'pending_customer' ) {
        return true;    // when user is a pending customer
    } else {
        return false;   // when user is not a pending customer
    }
}

is_user_pending_customer() is then used throughout the theme template to hide certain parts of the webpage from people in that user role.

Yes, the other roles show up in the recipient select dropdown with the correct user counts.

Hi Kuba,

Thanks for the prompt response.

I’m quite sure they’re actually separate custom roles. As a quick test, I ran the following code:

  $editable_roles = get_editable_roles();
    foreach ($editable_roles as $role => $details) {
        $sub = translate_user_role($details['name']);
        echo $sub . '<br>';
    }

Which produced this output:

Administrator
Customer
Shop Manager
Expired Customer
Shop Assistant
Pending Customer
On Hold

Yes, there’s a couple of admins, a ‘Shop Manager’, three ‘Shop Assistants’, a handful of editors, and 500-ish customer accounts.

Clearing the cache made it go away for two page loads, and then it returned.

Running the wp-rocket caching plugin on the affected site. Also running wp-rocket on an unaffected site; so I don’t think it’s the cause.

All sites are running on the same server.

Full list of plugins on the affected site:
InfiniteWP – Client by Revmakx – 1.9.2.1
Admin Menu Editor Pro by Janis Elsts – 2.9
Advanced Flat Rate Shipping For WooCommerce Pro by Multidots – 3.0.8 – Not tested with the active version of WooCommerce
Akismet Anti-Spam by Automattic – 4.1.2
All In One SEO Pack by Michael Torbert – 3.0.2
AutomateWoo – Referrals Add-on by Prospress – 2.3.2 – Not tested with the active version of WooCommerce
AutomateWoo by Prospress – 4.5.5
Better Menu Widget by Tracey Holinka – 1.5.1
Classic Editor by WordPress Contributors – 1.5
Crisp by Crisp – 0.24
Custom Sidebars by WPMU DEV – 3.2.3
Giftable for WooCommerce by Decom – 1.0.4 – Not tested with the active version of WooCommerce
HappyForms by The Theme Foundry – 1.8.8
Hide Featured Image by shahpranaf – 1.3.1
Homepage Control by WooThemes – 2.0.3
Login Logo by Mark Jaquith – 0.9.0
Mailchimp for WooCommerce by Mailchimp – 2.1.16 – Not tested with the active version of WooCommerce
SparkPost by SparkPost – 3.2.0
Storefront Blog Customiser by WooCommerce – 1.3.0
Storefront Blog Excerpt by Wooassist – 1.1.4
Storefront Footer Bar by WooThemes – 1.0.4
Storefront Hamburger Menu by WooCommerce – 1.2.2
Storefront Mega Menus by WooCommerce – 1.6.2 – Not tested with the active version of WooCommerce
Toggle wpautop by Linchpin – 1.2.5
WC Show All Reviews by AppJetty – 1.5.0 – Not tested with the active version of WooCommerce
WooCommerce UPC, EAN, and ISBN by Scott Bolinger – 0.4.0 – Not tested with the active version of WooCommerce
WC Autoship Product Page Options by Patterns in the Cloud – 1.1.4
WC Autoship Upsell by Patterns In the Cloud – 2.0.5
WC Autoship by Patterns in the Cloud – 4.1.18 – Not tested with the active version of WooCommerce
WooCommerce Stripe Gateway by WooCommerce – 4.2.0
WooCommerce Google Ads Conversion Tracking by Wolf+B?r Agency – 1.5.2
WooCommerce Google Analytics Integration by WooCommerce – 1.4.9
WooCommerce Print Invoices/Packing Lists by SkyVerge – 3.6.4 – Not tested with the active version of WooCommerce
WooCommerce Google Product Feed by Ademti Software Ltd. – 7.8.9
WooCommerce Product Search by itthinx – 2.13.3
WooCommerce Shipment Tracking by WooCommerce – 1.6.14
WooCommerce by Automattic – 3.6.4
WP Rocket by WP Media – 3.3.4
Custom Product Tabs for WooCommerce by YIKES, Inc. – 1.6.10
YITH WooCommerce Wishlist Premium by YITH – 2.2.9

Sorry, I’ve jumped the gun a little. We have one site on 3.0.2 that’s still affected. Will try to submit a ticket with your support later in the day if I get some time.

Seems to have resolved the issue for us on 7 affected sites.

Same issue here. Upgrade prompt ignores “no thanks” and keeps returning.

Seeing the same issue here. Look as though the WPAdverts website has been hacked.

We’re using this plugin. It’s a little old, but still works.

Thank you for the quick update.

I’m quite sure this was working as expected in 3.0 through to 3.2. Are we definitely talking about the same thing?

Our shop assistant is given a list of variations to enable/disable every Friday. We then generate a list of disabled variations to manually check that none are displaying on the front-end. There’s no way this has been broken for almost a year with nobody noticing.

Alright, fixed this with:

add_filter( 'woocommerce_hide_invisible_variations', '__return_true' );

It’s utterly perplexing that hiding “invisible” products isn’t the default behavior. A bug, surely?