thomasprice61

Opps,
Just found another one:

[24-Feb-2025 07:46:15 UTC] PHP Deprecated:  trim(): Passing null to parameter #1 ($string) of type string is deprecated in /home/customer/www/test.audax.org.au/public_html/wp-content/plugins/stafflist/stafflist.php on line 745

thank you

TEST CASE:

• The values in Advanced Settings were increased x4 (as the host is healthy)
• Scanning was noticeably faster … got to ~87% in under 20 seconds
• The 504 timeout issue still occurred

If it is the server triggering the 504 timeout would it not be based on time … say 120 seconds?
It seems to be based on ~87% completion … could some ‘bad data’ trigger this?

• This reply was modified 1 month, 2 weeks ago by thomasprice61.

Also, PHP variables are:

max_execution_time: 120
max_input_time: 120
memory_limit: 768M

But the timeout seems to happen after about 50 seconds

• This reply was modified 1 month, 2 weeks ago by thomasprice61.

More background information: https://make.www.ads-software.com/core/2024/10/21/i18n-improvements-6-7/

• This reply was modified 4 months, 1 week ago by thomasprice61.

I have the same issue.

The following may be related https://core.trac.www.ads-software.com/ticket/62337

• This reply was modified 4 months, 1 week ago by thomasprice61.

thank you

I will await the next release

please close as finally fixed in latest release.

Great to see. Kudos!!!

Hi ERA404,
Many thanks for 3.1.1
Nice use of namespaces, we will learn from it ??

regards Thomas

Hi ERA404,
Many thanks for making the change to the SimpleXLS(x) library set.
I hope it makes the management of the plugin easier for you.

One thing I noticed in your code.
You are calling the library without any exception handling … example:

require_once( STAFFLIST__PLUGIN_DIR . '/lib/shuchkin/SimpleXLSXGen.php' );

As this is a common library another plugin may use it, thus use the same class name.
If so there will be an error:

Fatal error: Cannot declare class SimpleXLSXGen, because the name is already in use in ...

To resolve this you could:
* use if ( !class_exists( 'SimpleXLSXGen' ) but that assumes the SimpleXLSXGen libraries will be identical (not a good assumption)
* use namespaces (best long term solution)
* rename the class ‘SimpleXLSXGen’ to ‘StaffList-SimpleXLSXGen’. A reasonable quick fix.

FYI, we chose to rename the class as a short term fix but plan to introduce namespaces sometime soon.

regards Thomas

• This reply was modified 3 years, 9 months ago by thomasprice61.
• This reply was modified 3 years, 9 months ago by thomasprice61.

Hi ERA404,
Just some small feedback… when Chrome Dev is used, the following errors occur:

DevTools failed to load SourceMap: Could not load content for https://test1.audax.org.au/wp-content/plugins/stafflist/lib/tippyjs/popper.min.js.map: HTTP error: status code 404, net::ERR_HTTP_RESPONSE_CODE_FAILURE
DevTools failed to load SourceMap: Could not load content for https://test1.audax.org.au/wp-content/plugins/stafflist/lib/tippyjs/tippy-bundle.umd.min.js.map: HTTP error: status code 404, net::ERR_HTTP_RESPONSE_CODE_FAILURE

This is resolved by modifying the last line (replace //# with //) in the 2 files:

• In popper.min.js // sourceMappingURL=popper.min.js.map, and
• in tippy.min.js // sourceMappingURL=tippy-bundle.umd.min.js.map

Note: I am not aware of this impacting your product, just housekeeping.

• This reply was modified 4 years, 2 months ago by thomasprice61.

Resolved, many thanks

regards
Thomas

• This reply was modified 4 years, 3 months ago by thomasprice61.

Hi Eddy,
I’m having the same issue
Will be a great tool if this is resolved

regards

StaffList in the WordPress states:
This plugin hasn’t been tested with the latest 3 major releases of WordPress. It may no longer be maintained or supported and may have compatibility issues when used with more recent versions of WordPress.
From an initial test, StaffList is fine in WordPress v5.5.
It would be great if the readme is updated:
Tested up to:5.5

regards