TiKu

Additional hint: We’re not yet using Gutenberg block editor, but still the old one.

The reason might be that this plugin still relies on jquery-migrations (for instance it uses .live() instead of .on()) which seems to have been removed from WordPress.

Okay. I managed to move my customizations in this area into my theme, by using the single_post_start action.

What’s the error generated by the first point?

No syntactical error, but which of the logical operators is executed first? The “||” or the “&&”? And if you can answer this, can you be sure that it will stay like this (because it is properly defined in the PHP language definition)?

Regarding the filters, I’m also trying to rework the output, but in my case I have no use for the raw elements. I would need the processed ones, held by $r. So I’ll end up duplicating code from the mpp_toc function.

Thanks a lot for this filter. It allowed me to remove some customizations of your code. But could it be that it does not allow having the TOC before the post’s featured image? It seems like $output does not contain the featured image when this filter is called.

For this reason I’m still using the single_post_start action. Currently I’m investigating whether I could at least move this action out of your plugin into my theme.

• This reply was modified 4 years, 5 months ago by TiKu.

Okay, I’ve applied. The request is pending.

Okay, I’ll try. In mpp-template.php there is this code:

$text = sprintf( __( 'Continue: %s', 'sgr-nextpage-titles' ), $link );
$text = sprintf( __( 'Back to: %s', 'sgr-nextpage-titles' ), $link );

So the strings to be translated are:

'Continue: %s'
'Back to: %s'

But in sgr-nextpage-titles.pot there are only (also note the trailing whitespace):

msgid "Back to: "
msgstr ""

and:

msgid "Continue:"
msgstr ""

So as far as I understand the po translation system, it is not possible to provide a proper translation for the two strings – even if the German translation would be maintained.
One way to solve this would be to move the %s out of the translatable string, as the initial poster did. Another way would be to fix the sgr-nextpage-titles.pot file so that it includes the %s.

Or am I misunderstanding the po translation system?

No, it is still the same.

@sgr33n Sorry, but you misunderstood. The code indeed is wrong. Have a close look at the first comment: The ‘%s’ has been moved outside the translation.

That’s not really a solution. I’ll edit each release of NextGen manually instead.

Hi @becky!

I cannot rollback this installation to v5.6 as this is a production system. But I have found out that the warning is related to PHP Strict Standards. So I guess you won’t see it in standard mode. See here – it is the same problem: https://php.net/manual/de/function.array-pop.php#114501

Best regards
TiKu

Should be version 7.0.31.

Is there any sample how to do such thing for a WP_Widget derived class that displays dynamic content?

Thank you, that did the trick. It was one of my own plugins. ^^

Thank you. I’ve found out that for me it is the Multipage Plugin. Disabling it fixes the problem. So I’ll dig into its code…