Gregory Karpinsky (@tivnet)

Thanks Paul.

Made a pull request. Resolving this, as nobody cares anyway ??
https://github.com/Yoast/wordpress-seo/pull/588

As of Version 1.4.24, still not fixed

Hello Cais,

Imagine a site using all big pictures, all thumbnails, slideshows, etc. – all with NextGEN, and then you click “upgrade” and suddenly all thumbnails are displayed as full-size, and when you try to fix it, you notice that all now completely different, and if you try to edit a post, all attached media become irreversibly corrupted?

Would you just smile and fill in a bug report? Or would you restore from backup and never try to upgrade again?

There could be tons of reasons for a new release to be incompatible. Could be changes in the WP core that you try to chase, or new features, or old bugs… I just do not have time to find out. Keeping old working version.

Yes, Wendihihihi, I did look at the settings. I also did look at the code, put there some debug output and noticed that the post content is being split into “tokens”, and if the terms happen to appear multiple times in the same token, the setting you mentioned does not work.
I could even fix that, but when I saw other bugs, I decided to drop it.

Which version? The only you have here. Just installed yesterday.
Cannot reproduce? Turn debug output on. Or just look at those lines in your code, and you will see that you do not check if the values exist.

About the “mess”:

You write things like
return self::display_forms_list($params, ”, false, false, $errors);
having void display_forms_list. So, what are you returning exactly?

Even worse example of the same:
__FRMSAVED=”<?php esc_attr(_e(‘Saved’, ‘formidable’)) ?>”;
What esc_attr? _e() does not return anything. It prints.

setup_edit_vars($record, $table, $fields=”
$fields is array. Why default value is string?

And so on. That in my eyes is a mess.

In addition to that, you infest the global space with your variables and defines. I do not want to use a plugin that has so many globals. Especially, with such simple prefix, ‘frm_’. Defines must be replaced with class constants. All globals must be replaced with only one, if you really need it.

Sorry.

A possible scenario: get_extra_permastruct, get_post_permalink or get_permalink called too early.
For example, it was called on plugins_loaded hook.

Calling it in init hook, or later (wp_loaded) should solve the problem.

Standards were always standards. In PHP 5.4 they just became more visible. Dynamic methods must not be called statically, and vice versa. There is nothing new about it. The v3 code is old, ugly and abandoned. V4, “Beta version” is timestamped on January. Almost a year ago.

Today we have PHP 5.5 and WP 3.7. This plugin is so behind…

@juanvillegas
Quoting myself:

… strict standards in PHP 5.4

It’s merged to the main repository:
https://github.com/bueltge/Debug-Objects

There were no errors, not on the screen and not in Apache/PHP logs.
Sorry, cannot try again because already uninstalled.

@joost de Valk:
Yes, it’s not new.
Having empty meta description is also bad.
What I did was add “paged” to the end of description and title. That helps.
In this specific case, the “Products” being on front page paginates and shows more and more products. I believe that without letting Google index all those pages, SEO will suffer (speaking from experience). So, I’d like to have them all “index, follow”, with title and description.

P.S. – Metas and Titles page with WooCommerce installed, in my opinion, needs some additional checking. “Pages”, “Products” and “Custom Post Type Archives” – they all become one thing when WooCommerce Products are displayed on the front page… OpenGraph is also affected, I think.

I am talking about the code in WooCommerce that fixes Yoast. When the “Products” (shop) is on the front page, Yoast does not know how to handle it, and WC fixes it by rooting Yoast to the proper page.
Then, the problem remains, because Yoast leaves all /page/2/ /page/3/ of the Products with no meta description. He explicitly says if “paged” then return, instead of printing <meta.

Obviously, it’s a Yoast problem. However, because you already trying to adjust to WC Yoast, same as you adjust to default WP themes, I thought you should re-check that part of code. That’s all.

// Fix WP SEO
if ( function_exists( 'wpseo_get_value' ) ) {
add_filter( 'wpseo_metadesc', array( $this, 'wpseo_metadesc' ) );
add_filter( 'wpseo_metakey', array( $this, 'wpseo_metakey' ) );
}

Thanks!

P.S. As we speak, there is a piece in WC code that does not have any hooks. It’s the widgets (recent products, random products, etc.). I do not think there is a way to do any customization there…

P.P.S. All “Products” pages display the same title, “Products”. I am using a post_type_archive_title filter to change it, because I could not find any WC hook.

Fixed in Version 1.9.7

Fixed in Version 1.9.7