tony721

Hi, Spencer.

Yes this update is working in mobile.
Terms (works), versions (works) hide menus (works), approve/ request changes. (works)

Only issue now is that in approve/ request changes the comment section works for Approved but is no longer working for the Not Approved section when its ticked.

Could this be a setting? or maybe the update? You can view for your self with the same link I provided.

Great work!
Much Appreciated.

Hi,

Any word on this as the updated plugin did not fix the mobile issue?

Regards.

Hi.

So I deleted the Design Approval System Version 4.0.8 and re download from WP org reactivated and tested on mobile but its the same issue.
I am also using the DAS Premium Version 1.0.0 should I delete and re download that too?

Really appreciate the help!
Thanks

Hi,

Actually I already spoke with them and they said to contact you quote below.

I just noticed that it works on first load on iPad, then stopped working after first click. This is common issue between click event and mobile touch event. Apparently, your plugin uses click event on mobile too that causes this issue, it should use touch event for mobile.

$(‘a’).on( ‘click’, function ( e ) {

//Do stuff upon clicking for desktop link
e.stopPropagation();

} );
—
$(‘a’).on( ‘touchend’, function ( e ) {

//Do stuff upon clicking for mobile link
e.stopPropagation();

} );

Your plugin’s script should be both desktop ad mobile friendly, and should able to detect which is mobile and desktop. If it’s mobile, then it has to unregister the click even registered for desktop.

$(‘a’).off(‘click’);
$(‘a’).on( ‘touchend’, function ( e ) {

//Do stuff upon clicking for mobile link
e.stopPropagation();

} );

Can you please have a look?
Thanks

Hi Spencer,

Sorry I had the plugin disabled due to testing.
I just re activated it can you please look again?

Thanks

Hi,

Ok thanks but I think it could be a conflict with my theme. I disabled all plugins but the issue was still there. Then I tested your demo on the same devices and it worked. If you could have a look at the link I provided in first post and maybe do some testing on your side via mobile as I cant find an error anywhere. I really need to get this fixed so I can launch the site.

Much appreciated,
Regards