Yohan Totting

We haven’t not test the plugin in multi sites setup. But in theory as long the sites has their own URL either in sub domain or sub directory it shouldn’t a problem.

Will be great if you can test it and provide any info if there is a problem with the site. The best way to check it is see if there is an error on WordPress or browser console when the plug-in is active. Will happy to help from there.

• This reply was modified 6 years, 1 month ago by Yohan Totting.

The issue seems only occur if the video is cached with service workers. This plugin only cache images and some static assets like JavaScripts, SVG, and fonts but not the video. So it should be okay. If you interested, this is our implementation for service worker with WorkBox library.

An update should be fix this issue. Please update the plugin to the latest one. Thanks.

Noted on this. We’re checking it out.

You can turn off async defer feature on MCW PWA plugin because Autoptimize has a same feature. But the others still works.

1. Redis works on server cache, so you can’t use Redis because service worker works on browser level. The service worker will serve your static assets like fonts, JS, and CSS files when it’s exist in browser caches. So Redis can’t use here.

2.Please remove the plugin and install it again, because I don’t change the version number. I tried to install the plugin directly on my WordPress and it’s work fine without AMP. AMP is optional, but will enhanced some performance by precache the page if AMP page loaded.

3. Your WordPress specs is fine. I haven’t try with multisite, but in theory it should work with that mode too.

Issue fixed, thanks for reporting and please try again.

Sorry this because my Git and WordPress SVN still not sync I’m currently working on synchronizing the repo between my Git repo and my SVN. And will push the update this week. Sorry for that.

The AMP plugin must be activated if you want to enable service worker install when user open your AMP page. But if you’re not install it then it still works fine without AMP plugin.

This is solved. Thanks

It’s like this. I have a class that call from main file of my plugin. Inside class contructor function I called through add_action.

protected function __construct() {
        add_action('wp_print_footer_scripts', array($this,'registerSW'),1000);
        add_action( 'template_redirect', array( $this, 'renderSW' ), 2 );
        add_filter( 'query_vars', array( $this, 'registerQueryVar' ) );
        add_action( 'init', array( $this, 'registerRewriteRule' ) );
        
 
        $this->registerAMPServiceworker();
        
    }

public function registerAMPServiceworker(){
        // AMP support
		add_action( 'amp_post_template_head', array( $this, 'renderAMPSWScript' ) );
		add_action( 'amp_post_template_footer', array( $this, 'renderAMPSWElement' ) );
    }

    public function renderAMPSWScript(){
        echo '<script async custom-element="amp-install-serviceworker" src="https://cdn.ampproject.org/v0/amp-install-serviceworker-0.1.js"></script>';
        
    }

    public function renderAMPSWElement(){
        echo '<amp-install-serviceworker src="'.$this->getSWUrl().'" layout="nodisplay"></amp-install-serviceworker>';
    }

• This reply was modified 7 years, 2 months ago by Yohan Totting.