Unsacsurledos

Hi !

Thanks for your reply.
Any news regarding this ?
Some beta maybe ?

thanks in advance ??

Hello neotrope,

thanks for your reply.

In fact it’s not a bug, but a suggestion.

When FB says to use a 1200×630 file, it’s because they are waiting for that size for high resolution, so passing a 600×450 file like for twitter, will not give me high resolution in FB.

The posts looks poorly on high definition computer screens, such as for example retina macbook from Apple. Even if the file in OG is a 2400*1600, as I explained in my first post. ??

Is there another place where I can send my suggestion if not this support plugin area ?

Have a nice day ??

I’ve found where the error is appearing, but I can’t figure out how to correct it. The problem appears when more than 2 pictures appears in the articles, they can be in a gallery or not, doesn’t matter. So 2 continuous pictures is OK, more is wrong. The code of page frog is here :

$image_nodes = array();
        for ($index = 0; $index < $node->childNodes->length; $index += 1) {
            $child = $node->childNodes->item($index);

            // if it's not an element node, continue past
            if ($child->nodeType != XML_ELEMENT_NODE)
                continue;

            if ($child->nodeName == 'figure' && $this->getFirstDecendantByNodeName($child, 'img') != NULL)
                array_push($image_nodes, $child);
            else {
                if (count($image_nodes) > 1) {
                    $slideshow_node = $this->dom->createElement("figure");
                    $slideshow_node->setAttribute("pagefrog-ignore", "true");
                    $slideshow_node->setAttribute("class", "op-slideshow");
                    foreach ($image_nodes as $image_node)
                        $slideshow_node->appendChild($image_node);
                    $node->insertBefore($slideshow_node, $child);
                    $image_nodes = array();
                }
                else {
                    $image_nodes = array();
                }
            }
        }

have no idea why the $image_nodes always have 2 pictures when it could have more (value got through count($images_nodes).

Anybody have an idea ?

This code is in class_pagefrog_instant_articles_parser.php

Same problem here, still searching why…

No proposition ?

More technical information :

plugin version 2.8
PHP 7.0
mysql 5.6.28

stranger is that with latest release of MAMP for Mac, in localhost, I don’t have the accents problem…

Same problem, can’t understand why this occurs only with this plugin and not on the rest of website…

Thanks manoj007 ??

Have same problem here, for example, all articles page loads in 20 seconds.

Have done a pcap network capture, but I can understand it ??

But what I understand, and from what i’ve already tested, it looks like it’s not a database size/speed problem, but more timeouts/pings/pingbacks with other servers. I have no idea how to solve this.

I’ve got 20 plugins installed, 18 of them could not be removed :s

Ok Claudio,

I can understand it could be a pain for you in the support if you do that. As a developer I can imagine the bug requests you could receive, so OK, I understand your argument and validate it. ??

Thanks for the time taken to respond me and long life to your plugin !

Hello Claudio,

yes, you’re right, I’ve pasted my first try of code modification instead of the final version, then it would be :

if ( $color == '#333333' ) {
	$html .= sprintf( '<span class="count">%s</span>', apply_filters( 'social_count_plus_number_format', $count ) );
	$html .= sprintf( '<span class="label">%s</span>', $color, $title );
	}
else {
	$html .= sprintf( '<span class="count" style="color: %s !important;">%s</span>', $color, apply_filters( 'social_count_plus_number_format', $count ) );
	$html .= sprintf( '<span class="label" style="color: %s !important;">%s</span>', $color, $title );
	}

The goal is to have a neat code when possible (it’s to say when standard, when user doesn’t change the default color). Surely it will work with inside styles, but I think it’s always better when styles are in css classes than repeated inline.

I suppose that most of users don’t have more than 6 (I’ve personally 3) counters, so i suppose the “if” would not be something that eat processor time.

What do you think ? As I said initially, it’s not a big deal, just a little enhancement proposition ??

Thanks Claudio for the proposition,

I’m not a git-aware person, but I’ve tested this code in my dev environment and seems to work : juste replace line 956 and 957 but those :

if ( isset( $design['text_color'] ) ) {
	$html .= sprintf( '<span class="count">%s</span>', apply_filters( 'social_count_plus_number_format', $count ) );
	$html .= sprintf( '<span class="label">%s</span>', $color, $title );
	}
else {
	$html .= sprintf( '<span class="count" style="color: %s !important;">%s</span>', $color, apply_filters( 'social_count_plus_number_format', $count ) );
	$html .= sprintf( '<span class="label" style="color: %s !important;">%s</span>', $color, $title );
	}

Thanks you for your great reactivity !

Oh OK, i’ve just read the PHP code, and rechecked the plugin panel, you are right.
So maybe it could be interesting to have a checkbox option to enable personal colors or to consider 333333 as a default color and so to not show it in the generated code ?

What do you think ? I know it’s a bigger change than I thought firstly ??