Derek Herman

They will tell you no. If you want to fix it then contribute a patch on GitHub.

@fxvisuals It should be available for download shortly. Please test it and let me know.

The isn’t really as much an OptionTree issue as it is Core not adding display and visibility to the style attributes array in the safe_style_css filter. If you changed the style to something else it works. However, I’ve patched it and I’m deploying another version in a few minutes that I know works. And it will make it easier to extend if someone needs other attributes besides those two and the ones here https://core.trac.www.ads-software.com/browser/tags/5.1.1/src/wp-includes/kses.php#L2068

Hi @mevikrambisht, thank you for reviewing the plugin. However, I wanted to bring something to your attention. You’re giving OptionTree a one star review based on custom code implemented in your theme. There is not a theme-interface.php file in OptionTree. Could you please remove this review or change it to reflect actual OptionTree functionality that you’ve reviewed.

The updated OptionTree version 2.7.1, which fixes the issue, will be available by the top of the hour.

OptionTree version 2.7.1 fixes both the missing noscript tag and iframe style attribute for users with unfiltered_html capabilities. Version 2.7.1 should be available by the top of the hour. Thank you for finding the issue.

One thing to note is that the old Google font API key in OptionTree doesn’t work anymore so you have to add your own key with the ot_google_fonts_api_key filter.

What version of OptionTree?

That is a very old version of OptionTree and you’re asking for help with your custom theme code that is being called in functions.php. It’s out of scope for this support forum.

You should look in the error logs to see what’s broken and I’d recommend upgrading OptionTree in a controlled environment to test that it can be.

Or this a code in your theme and again, I cannot help you fix it. Other than to say Undefined index: hover means that you have a variable that needs to be declared before you use it. So go to line 134 and add a $hover = ''; somewhere before it in an appropriate place.

OptionTree does not have a theme-interface.php file, you have a modified copy and I cannot help you fix it. Sorry.

This can be fixed with a filter. Try this and let me know if it fixes it and I’ll patch the plugin.

add_filter( 'ot_allowed_html', function( $tags ) {
    $tags['noscript'] = array();

    return $tags;
}, 10, 1 );

However, the fact is says the typography option type gives me some concern because it’s sanitized above in the code. Maybe someone extended the option type in your theme?

@insearchofasolution The ot_validate_setting_input_safe notice means you have a custom option type that is not using the new filter. It’s technically harmless, unless the data is not being saved after being ran through _sanitize_recursive. In order to ensure the data is being sanitized and validated correctly I had to create a way to notify users that the old way is wrong but still try and sanitize the data. In most cases things will be fine but the notice is there to let you know a custom option type needs to be updated to use the new ot_validate_setting_input_safe filter.

I’ll push out a hotfix version tomorrow.