Forum Replies Created

Viewing 15 replies - 1 through 15 (of 18 total)
  • Thread Starter vgstudios

    (@vgstudios)

    Can you please update the MainWP Child plugin on those sites to the latest version v4.5.2, and see if that helps?

    I wouldn’t be surprised if it would work after updating the MainWP Child Plugin to the latest version.
    However the WordPress core versions on those sites are older (4.x) than the what the latest MainWP child plugin demands (5.4 or higher) and I am not allowed to update those sites.

    Maybe updating the system requirements ( https://kb.mainwp.com/docs/system-requirements/ ) where it still says WordPress 3.6+ could be helpful for some.

    Thank you for your reply.

    We have the same problem.

    The error message is wrong username / password

    It only happens when accessing the /login/ page the first time (e.g. use private browsing) AND using WP Super Cache.

    I worked around it for now using
    if(!defined('DONOTCACHEPAGE')) define('DONOTCACHEPAGE', true);
    at the top in the theme-my-login/includes/class-theme-my-login-form.php render_form function.
    This is of course not the most optimal workaround I guess, since it will uncache all pages where the form appears.

    Thread Starter vgstudios

    (@vgstudios)

    Hi. I didn’t know that, sorry. Thank you very much for your efforts and your plugin. I guess the issue will be resolved then.

    Thread Starter vgstudios

    (@vgstudios)

    Original site (fixed a bit by placing the CSS above, since it’s a live site I can not leave it as is):
    https://www.k-events.co.il/
    This still jumps though on first open of the captcha.
    This site uses the popular Impreza premium theme.
    (The hCaptcha is on CF7 and checkout.)

    Test site I set up with a different theme (WiPi.co.il):
    https://hcaptcha.lp.vagas.co.il/
    This site doesn’t need the CSS fix in order to not break the page, but it still jumps to the top of the page on every open of the captcha.
    (The hCaptcha is on CF7.)
    Edit: the CF7 / captcha is a the bottom of the page.

    So the design breaking is theme specific, but the jumping to top on opening hCaptcha is not.

    If you want me to modify the testsite to have the Impreza premium theme temporarily, let me know please.

    • This reply was modified 2 years, 4 months ago by vgstudios. Reason: added captcha location info
    Thread Starter vgstudios

    (@vgstudios)

    
    /* Fix hCaptcha CSS */
    
    body > div[aria-hidden="true"] {
      border: 0;
      clip: rect(1px, 1px, 1px, 1px);
      clip-path: inset(50%);
      height: 1px;
      margin: -1px;
      overflow: hidden;
      padding: 0;
      position: absolute;
      width: 1px;
      word-wrap: normal !important;
    }
    

    It seems it was already broken in one of the previous updates / has already the same problem there.

    Thread Starter vgstudios

    (@vgstudios)

    Thank you :]

    Not sure if this is sufficient for you, but that’s what we did:

    diff --git a/src/themeszone-woocommerce-ajax-quantity/public/js/tz-wc-ajax-qty-public.js b/dst/themeszone-woocommerce-ajax-quantity-vgs/public/js/tz-wc-ajax-qty-public.js
    index cdde308..c21d751 100644
    --- a/src/themeszone-woocommerce-ajax-quantity/public/js/tz-wc-ajax-qty-public.js
    +++ b/dst/themeszone-woocommerce-ajax-quantity-vgs/public/js/tz-wc-ajax-qty-public.js
    @@ -1,13 +1,13 @@
     (function( $ ) {
     	'use strict';
     
    -	$( window ).load(function() {
    +	$( window ).on('load', function() {
     
     		if ( typeof tz_call === 'undefined' ) {
     			return false;
     		}
     
    -		$('.tz-qty-cont').live('click', function(){
    +		$('body').on('click', '.tz-qty-cont', function(){
     
     			var qty_input = $(this).parent().find('input[name="quantity"]');
     			if ( $(qty_input).prop('disabled') ) return;
    @@ -40,9 +40,9 @@
     				'tz_qty_get_form_data': data      // We pass php values differently!
     			};
     
    -			var qty_form = $(sender).parents('li.product').find('.tz-qty-container');
    -			var pos = $(sender).parents('li.product').find('a.button[data-tz_qty_ajax="true"]');
    -			var vv = $(sender).parents('li.product').find('a.added_to_cart');
    +			var qty_form = $(sender).parents('.w-grid-item.type-product').find('.tz-qty-container');
    +			var pos = $(sender).parents('.w-grid-item.type-product').find('a.button[data-tz_qty_ajax="true"]');
    +			var vv = $(sender).parents('.w-grid-item.type-product').find('a.added_to_cart');
     			if ( pos.length && qty_form.length ) {
     				pos.hide();
     				vv.remove();
    @@ -50,7 +50,6 @@
     				qty_form.removeClass('hidden');
     				qty_form.show();
                 }
    -
     		});
     
     		$ ( document.body ).on('added_to_cart', function(env, fragments, cart_hash, $thisbutton){
    @@ -59,8 +58,8 @@
     				$.post(tz_call.ajax_call_path, tz_qty_query, function(response, status) {
     					if ( status == 'success' ) {
     
    -						var qty_form = $thisbutton.parents('li.product').find('.tz-qty-container');
    -						var h_field = $thisbutton.parents('li.product').find('input[data-product_id]');
    +						var qty_form = $thisbutton.parents('.w-grid-item.type-product').find('.tz-qty-container');
    +						var h_field = $thisbutton.parents('.w-grid-item.type-product').find('input[data-product_id]');
     						$(h_field).data('cart_id', response.cart_id);
     						var inp = qty_form.find('input.qty');
     						$(inp).val(response.qty);
    @@ -78,11 +77,11 @@
     			$( document.body ).trigger('after_adding_to_cart', [ obj, data ] );
     		});
     
    -		$( '.tz-qty-container .quantity input.qty' ).live( 'change', function() {
    +		$('body').on('change', '.tz-qty-container .quantity input.qty', function() {
     
     			if ( $(this).prop('disabled') ) return;
     
    -			var inputattrs = $(this).parents('li.product').find('input[data-product_id]');
    +			var inputattrs = $(this).parents('.w-grid-item.type-product').find('input[data-product_id]');
     
     			var args = {};
     
    @@ -93,8 +92,8 @@
     			args['qty'] = parseFloat($(this).val());
     			var cur_qty = args['qty'];
     
    -			var buy_but = $(this).parents('li.product').find('a.add_to_cart_button');
    -			var qty_form = $(this).parents('li.product').find('div.tz-qty-container');
    +			var buy_but = $(this).parents('.w-grid-item.type-product').find('a.add_to_cart_button');
    +			var qty_form = $(this).parents('.w-grid-item.type-product').find('div.tz-qty-container');
     
     
     
    @@ -159,6 +158,7 @@
     
     				// Trigger event so themes can refresh other areas
     				$( document.body ).trigger( 'cart_qty_update', [ fragments, cart_hash ] );
    +				$( document.body ).trigger( 'wc_fragments_refreshed' );
     
     			});
     
    @@ -169,7 +169,7 @@
                	var removed_product = args.context.dataset.product_id;
                	var product_removed_button = $('[data-product_id="'+removed_product+'"]')
     		   	if ( product_removed_button.length && product_removed_button[0].hasAttribute('data-tz_qty_ajax') ) {
    -           		var product_container = product_removed_button.parents('li.product');
    +           		var product_container = product_removed_button.parents('.w-grid-item.type-product');
                		if ( product_container.length ) {
                			var inp = product_container.find('.tz-qty-container .quantity input.qty');
                         inp.val(0);
    diff --git a/src/themeszone-woocommerce-ajax-quantity/templates/qty-form.php b/dst/themeszone-woocommerce-ajax-quantity-vgs/templates/qty-form.php
    index 1e72b95..3a14b4f 100644
    --- a/src/themeszone-woocommerce-ajax-quantity/templates/qty-form.php
    +++ b/dst/themeszone-woocommerce-ajax-quantity-vgs/templates/qty-form.php
    @@ -1,6 +1,6 @@
     <?php global $cart_item_info, $product, $form_visible, $link; ?>
     <div class="tz-qty-container <?php echo ( $form_visible ) ? '' : 'hidden'; ?>">
    -	<span class="tz-qty-cont minus">-</span>
    +	<span class="tz-qty-cont plus">+</span>
     	<?php
     	$cur_qty = isset($_POST['quantity']) ? wc_stock_amount( $_POST['quantity'] ): wc_stock_amount ( $cart_item_info['qty']) ;
     	woocommerce_quantity_input( array(
    @@ -11,5 +11,5 @@
     	) );
     	echo sprintf( '<input type="hidden" data-product_id="%s" data-product_sku="%s"  data-cart_id="%s" class="%s hidden button product_type_simple">', esc_attr( $product->get_id() ), esc_attr( $product->get_sku() ),  esc_attr($cart_item_info['key']) ,esc_attr( $link['class'] ) );
     	?>
    -	<span class="tz-qty-cont plus">+</span>
    +	<span class="tz-qty-cont minus">-</span>
     </div>
    \ No newline at end of file
    diff --git a/src/themeszone-woocommerce-ajax-quantity/themeszone-wc-ajax-qty.php b/dst/themeszone-woocommerce-ajax-quantity-vgs/themeszone-wc-ajax-qty.php
    index 4e2fe5e..f79c9d0 100644
    --- a/src/themeszone-woocommerce-ajax-quantity/themeszone-wc-ajax-qty.php
    +++ b/dst/themeszone-woocommerce-ajax-quantity-vgs/themeszone-wc-ajax-qty.php
    @@ -13,10 +13,10 @@
      * @package           TZ_WC_Ajax_Qty
      *
      * @wordpress-plugin
    - * Plugin Name:       Themes Zone WC Ajax Quantity
    + * Plugin Name:       Themes Zone WC Ajax Quantity (Vagas VGS mod)
      * Plugin URI:        https://themes.zone/themes-zone-woocommerce-ajax-quantity-plugin/
      * Description:       Plugin adds a quantity filed on product listing page when customer clicks on add to cart button, thus allowing customers to change product quantity without having to go to the shopping cart to change the number of products.
    - * Version:           1.2.2
    + * Version:           1.2.3
      * Author:            Themes Zone
      * Author URI:        https://themes.zone/
      * License:           GPL-2.0+
    

    You will need to adjust .w-grid-item.type-product to the actual value for yout theme, this is for the Impreza theme we use on that site.

    Also probably you won’t need to swap plus and minus like us, since this is for an RTL site.

    Thread Starter vgstudios

    (@vgstudios)

    Hi. Thank you. Sadly I got not notified of your reply, but we noticed it was fixed, because now our fix was causing it to be wrong xD

    Thanks again, have a good day!

    Thread Starter vgstudios

    (@vgstudios)

    Hi. Thanks for your reply.

    On https://www.hybh.co.il/
    there’s a menu with a sub menu that has sub menu items that slide out:
    https://ibb.co/7gH9S1Q

    The screenshot already shows the fix with the CSS, without the fix the JS code would make it open to the right, which seems suboptimal for RTL (which sould open to the left by default).

    Thread Starter vgstudios

    (@vgstudios)

    Hi.

    Firstly, thank you very much for the update:

    v 1.5.0 – 2019-10-26
    Added: Ability to add ‘From’ and ‘Reply-To’ mail addresses for Applicant notifications in settings.

    That’s already much of a relief.

    It’s weird though, that it has been only added for those and not for other emails by the plugin (e.g. to admin).
    It still uses admin email as from address there, which will cause it go to spam under many conditions, if the admin email is not on same domain as the WordPress site.

    Is it possible to look into this for the free or pro version?

    Same :]

    Thread Starter vgstudios

    (@vgstudios)

    Thank you for your reply.
    Looking forward to the next update(s).

    With kind regards

    Thread Starter vgstudios

    (@vgstudios)

    Thank you for your replies ??

    Thread Starter vgstudios

    (@vgstudios)

    Thank you very much ??

    Thread Starter vgstudios

    (@vgstudios)

    I want to add I tested and xmlrpc.php and wp-login.php protection seem to be working.

    Sadly I didn’t think of an TCPdump in-time, so I will never know what that XMLrpc attack was about.

Viewing 15 replies - 1 through 15 (of 18 total)