Forum Replies Created

Viewing 8 replies - 1 through 8 (of 8 total)
  • Thread Starter Webrocker

    (@webrocker)

    Thank you Dennis.
    Can confirm that this setting/checkbox is active in the install that errored

    Thread Starter Webrocker

    (@webrocker)

    hi dennis, thanks for the fast reply (and the cool plugin).
    I’ll dig deeper and if need be, create a test-instance and get back to you via the support form for pro.

    Webrocker

    (@webrocker)

    Had the same Warning.

    Instead of just removing the ampersand as noted above, I made the reference inside that function:

    public static function substituteToken( $match ) {
     // global $wp_syntax_token, $wp_syntax_matches;
     // &$match was in the function param before:
     $m = &$match;
     $i = count( self::$matches );
     self::$matches[ $i ] = $m;
     return "\n\n<p>" . self::$token . sprintf( '%03d', $i ) . "</p>\n\n";
    }
    

    plus I had to change “create_function()” in geshi/geshi.php l 4750ff to a regular funcion:

    if (!isset($callback_2)) {
     // throws error in php8:
     //$callback_2 = create_function('$matches', 'return "[" . str_replace("|", "", $matches[1]) . "]";');
     // works:
     $callback_2 = function($matches){
     return "[" . str_replace("|", "", $matches[1]) . "]";
     };
    }
    

    (https://www.php.net/manual/en/function.create-function.php) is no more in PHP8

    this seems to have fixed the warning/errors for me.

    • This reply was modified 2 years ago by Webrocker.
    • This reply was modified 2 years ago by Webrocker. Reason: code formatting and comments
    • This reply was modified 2 years ago by Webrocker.

    I have installed it in a 5.3.2 and it seems to work as expected, with one exception; image crops are always from center/center even with other postitions declared like “center”,”top”.
    I dug around in the code and I found an error, and fixed it, but the crop positions are ignored, still. I think it is a problem with WP 5.x own image scaling and the resulting “original-image-scaled-123×123.jpg” files.
    Anyway, here is the bug line:
    (in simple-image-sizes/classes/admin/Media.php line 407:)

    
    $crop = '["' . $crop[0] . '", "' . $crop[1] . '")';
    

    should be

    
    $crop = '["' . $crop[0] . '", "' . $crop[1] . '"]';
    

    (also on github: https://github.com/Rahe/Simple-image-sizes/issues/59 )

    cheers,
    Tom

    • This reply was modified 4 years, 8 months ago by Webrocker.

    The same plugin name is a problem for my clients, so a new name for your plugin would be great.

    Hi, as mentioned in your github issues, the problem that Thomas describes for users of the orginal plugin remains even after renaming your plugin. Two of my (old) installs got updated to your plugin. I suspect it is precisley because of the plugin URL/SVN address – so WordPress instances “think” this is the codebase of the old “myGallery” install.
    I think the impact is bad for those affected, in my case it was just an annoyance because I already migrated away from “myGallery” and just had the plugin deactivated in the install. I don’t know how many active installs are left out there; supposedly they died out over the PHP upgrades 5 -> 7.
    The whole thing makes wonder about WordPress’s way of handling outdated plugins. Theoretically all one needed to “hijack” WordPress installs is to find an since deleted plugin, and use it’s URL to inject your own code in installs still using that plugin. This just doesn’t feel right. ??

    I think with the new version (2.0) this may be possible via the newly implemented hooks which will allow for tweaking of the output via a plugin or code added to the functions.php inside the theme directory.
    Unfortunatly I am not very experienced with hooks, filters, actions and the api, so hopefully someone else will chime in…

    There are the fields “post_type” and “post_parent”, “post_mime_type” and
    “guid” in the wp_posts table.
    for example:

    post_type=attachment
    post_mime_type=image/gif
    guid=[yourblogurl]/blog/wp-content/uploads/2006/01/example.gif

    I have no idea how to re-import my mediafiles from older post that were uploaded via a plugin into the current media-library, though.

    uhm… why don’t use the “number” argument with a value of “0” (zero)?
    As stated in https://codex.www.ads-software.com/Template_Tags/wp_tag_cloud :

    number
    (integer) The number of actual tags to display in the cloud. (Use ‘0’ to display all tags.)

Viewing 8 replies - 1 through 8 (of 8 total)