Weston Ruter

In any case, you don’t need to install the plugins via the Performance screen. You can install them directly. Just search the directory for the plugins listed in the plugin description: https://www.ads-software.com/plugins/performance-lab/

Well, it seems that the API request is not returning the expected plugins.

This is the PHP code that seems to not be returning the expected data: https://github.com/WordPress/performance/blob/762df7464d293ec7dcd46ad19d0e6ceb5f81fcb9/plugins/performance-lab/includes/admin/plugins.php#L36-L56

I don’t suppose you could find a way to run that PHP code on your site and do a var_dump() to see what it contains?

@gordonrjones Here’s one better for you. You can install the performance-lab.zip linked to from the PR comment I just left. That includes the updated strings, so we’ll be able to narrow-down where the error is coming from.

PR for improving the translation strings: https://github.com/WordPress/performance/pull/1651

• This reply was modified 1 week, 2 days ago by Weston Ruter.

@gordonrjones There are three possible locations where this error could be coming from:

1. https://github.com/WordPress/performance/blob/7c6aa818b5c9707d7619a91614548ef51efba033/plugins/performance-lab/includes/admin/plugins.php#L28
2. https://github.com/WordPress/performance/blob/7c6aa818b5c9707d7619a91614548ef51efba033/plugins/performance-lab/includes/admin/plugins.php#L86
3. https://github.com/WordPress/performance/blob/7c6aa818b5c9707d7619a91614548ef51efba033/plugins/performance-lab/includes/admin/plugins.php#L363

All three are in that same file: includes/admin/plugins.php. Unfortunately we’re reusing the same string for each error. Are you comfortable editing the strings in the plugin file editor in WordPress to, for example, add __LINE__ after the strings so we can differentiate between them? This will help us debug where the error is coming from.

Aside: I also see that we’re using the string with the default text domain once, but with the performance-lab text domain twice. That’s not good either. I’ll open a PR to fix this for the next release, as well as to make the strings unique.

It’s possible, but I doubt it’s something we’d prioritize.

Hello! I believe you are reporting what is currently being tracked here: https://github.com/WordPress/performance/issues/1576

The object-cache.php installation is designed to be compatible with any existing caching layer. In particular, if you have an existing object-cache.php it will copy that one and then continue to load it after the Performance Lab’s version is installed: https://github.com/WordPress/performance/blob/01504c5493ef71e355ac6e9f5165e938729c46cc/plugins/performance-lab/includes/server-timing/object-cache.copy.php#L76-L86

Is this not working for you?

That said, you can disable it from being installed by adding define( 'PERFLAB_DISABLE_OBJECT_CACHE_DROPIN', true) to your wp-config.php.

In any case, the use of object-cache.php as a means to start early timing is a hack. It would be great if we could use a different mechanism to start timing early, like installing an mu-plugin.

An update on this: The issue has been fixed in the canary version of Edge, and the fix should be included in the next stable release, according to https://issues.chromium.org/issues/365490302#comment10

• This reply was modified 2 weeks, 3 days ago by Weston Ruter.

You can also opt to use img instead of amp-img now in the AMP plugin settings.

I don’t see how that would cause a crash. What do you mean by crash? Does the site not crash when the PWA plugin is deactivated?

As for fixing the PHP Notice, this is something that Avada would need to do. They’re not calling the register method properly.

What is the error message?

Do you have a stack trace?

I’ve mentioned this support topic on a related GitHub issue: https://github.com/WordPress/performance/issues/1396

Correction from @tunetheweb. The 'inline-speculation-rules' directive value wouldn’t work. It would only work for Speculation Rules added via scripting. So yeah, it seems the nonce is the best bet.

Alternatively, you can add the 'inline-speculation-rules' directive value to your CSP, instead of adding a nonce. h/t @tunetheweb