wildmice

oops, sorry – using current version of free version of mapsmarker and latest WordPress – on PHP 7 hosting

I can confirm this problem in version 5.0.1 and it’s a pretty serious flaw as it can cause you to lose all that carefully crafted CSS which is probably not backed up in a way that’s easy to restore. Fortunately, using the browser back button got it back for me, but this was too close a call and i’ve now moved that CSS to a safer place (child theme stylesheet).

Hi. I’ve not been able to find any details about how this is implemented in Plesk (using Plesk 12.5). I’m guessing that it’s done in server config settings, rather than htaccess, as i’ve never seen anything set by it in htaccess.

Hi David,

We are looking further into this.

While i agree with you that the actual update process does not run the plugin, if you update it manually on the plugins page i do believe it gets loaded after the update and any error would then show. Also, of course, it’s usually loaded when a page loads (after updating) and can throw an error then.

I’ve certainly seen my share of plugins that fail immediately after i update them from the plugins page, before i’ve left the plugins page. If a plugin is not loaded right after upgrade, what good would the upgrader_process_complete hook be?

In this case i arrived on the plugins page to discover a red error message at the top of the page, indicating that an error 500 had taken place earlier.

I then re-uploaded the previous version of UpdraftPlus by FTP and tried the update manually (the first time was an automatic update). I then got another error 500 that displayed inline with the plugin on the plugins page. In that case WordPress was left in maintenance mode and the site was down.

While it’s not clear to me whether this is a plugin or server problem, i think it’s a bit misleading to suggest/imply that this error could not be caused by UpdraftPlus.

Does your plugin try to communicate with the outside world right after an update? or rely at that time on any service that could possibly not respond quickly enough?

After looking at this more closely, we noticed that of the 3 websites that we have on this vps, only this one had a problem updating. The other 2 updated successfully to the same version of the plugin that failed to update on the site mentioned above. From our end it does not look like a server setting is influencing this.

sorry, i wrote “update” in the title and should have put that in the body too. the error is when upgrading.

Here ya go David…

2017-03-07 00:29:55 Error 208.69.242.80 500 POST /wp-admin/admin-ajax.php HTTP/1.0 https://kootenaydentalarts.com/wp-admin/plugins.php Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:51.0) Gecko/20100101 Firefox/51.0 1.57 K Apache access

2017-03-07 00:30:35 Warning 208.69.242.80 mod_fcgid: read data timeout in 40 seconds, referer: https://kootenaydentalarts.com/wp-admin/plugins.php Apache error

2017-03-07 00:30:36 Error 208.69.242.80 End of script output before headers: admin-ajax.php, referer: https://kootenaydentalarts.com/wp-admin/plugins.php Apache error

2017-03-07 00:30:51 Error 208.69.242.80 503 POST /wp-admin/admin-ajax.php HTTP/1.0 https://kootenaydentalarts.com/wp-admin/plugins.php Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:51.0) Gecko/20100101 Firefox/51.0 593 Apache access

After that i was getting 503 errors because the upgrade never exited from maintenance mode.

Hi Frank ??

In this case i inherited a large, very slow site with around 60 plugins and well over 200 resources to fetch. I wanted to get that down to 128 resources.

Luckily, using AO the normal way was good in this situation, and it brought the number down to 138. Not perfect, but it reduced the load time from 14.5 to about 11.5 seconds.

This is what got me thinking that for even larger sites it would be useful to be able to aggregate into several rather than one single file. So if we could simply specify the number of files we wanted for css and for js, then we could tweak things to bring the number of resources down to the point of optimum performance.

Shanna

Hi David. Here is the schema of the tables involved. Sorry, i don’t know which plugin these tables are for, as i’ve inherited a site with over 60 plugins and it’s not obvious from the table name.

~shanna
=============================

CREATE TABLE bRF8BR2o_crw_crosswords (
project varchar(190) NOT NULL,
name varchar(190) NOT NULL,
crossword text NOT NULL,
first_user bigint(20) unsigned NOT NULL,
last_user bigint(20) unsigned NOT NULL,
pending tinyint(1) NOT NULL DEFAULT ‘0’,
PRIMARY KEY (project,name),
CONSTRAINT bRF8BR2o_project_crossword FOREIGN KEY (project) REFERENCES bRF8BR2o_crw_projects (project) ON UPDATE CASCADE
) ENGINE=InnoDB DEFAULT CHARSET=utf8 ;

CREATE TABLE bRF8BR2o_crw_editors (
project varchar(190) NOT NULL,
user_id bigint(20) unsigned NOT NULL,
PRIMARY KEY (project,user_id),
CONSTRAINT bRF8BR2o_project_editors FOREIGN KEY (project) REFERENCES bRF8BR2o_crw_projects (project) ON DELETE CASCADE ON UPDATE CASCADE
) ENGINE=InnoDB DEFAULT CHARSET=utf8 ;

CREATE TABLE bRF8BR2o_crw_projects (
project varchar(190) NOT NULL,
default_level int(11) NOT NULL,
maximum_level int(11) NOT NULL,
used_level int(11) NOT NULL,
PRIMARY KEY (project)
) ENGINE=InnoDB DEFAULT CHARSET=utf8 ;

Ok, so this turned into a messy pile of code above and i’ve decided to post a link to my own modified version of this plugin, which addresses these concerns until the developer gets around to it. This is a drop-in replacement and you’ll easily be able to go back to the real thing at any time.

https://wildmice.ca/downloads/simple-share-buttons-adder-fixed-6.3.4.zip

Ok, so this turned into a messy pile of code above and i’ve decided to post a link to my own modified version of this plugin, which addresses these concerns until the developer gets around to it. This is a drop-in replacement and you’ll easily be able to go back to the real thing at any time.

https://wildmice.ca/downloads/simple-share-buttons-adder-fixed-6.3.4.zip

Please see my separate post on the confusing distinction of excerpts vs categories/archives. I have fixed this for my own use and posted the code changes.

https://www.ads-software.com/support/topic/confusing-functionality-excerpts-and-categoriesarchives/

Note that WordPress converts single quotes to curly quotes. You’ll have to fix those in the code posted here.

I made a small change to this function :

// check if this page requires buttons
function ssba_are_buttons_required($arrSettings) {

if (isset($arrSettings[‘ssba_pages’]) && $arrSettings[‘ssba_pages’] == ‘Y’ && is_page()) return TRUE;
else if (isset($arrSettings[‘ssba_posts’]) && $arrSettings[‘ssba_posts’] == ‘Y’ && is_single()) return TRUE;
else if (isset($arrSettings[‘ssba_cats_archs’]) && $arrSettings[‘ssba_cats_archs’] == ‘Y’ && is_category()) return TRUE;
else if (isset($arrSettings[‘ssba_cats_archs’]) && $arrSettings[‘ssba_cats_archs’] == ‘Y’ && is_archive()) return TRUE;
else if (isset($arrSettings[‘ssba_homepage’]) && $arrSettings[‘ssba_homepage’] == ‘Y’ && is_home()) return TRUE;
else if (isset($arrSettings[‘ssba_homepage’]) && $arrSettings[‘ssba_homepage’] == ‘Y’ && is_front_page()) return TRUE;
else if (isset($arrSettings[‘ssba_excerpts’]) && $arrSettings[‘ssba_excerpts’] == ‘Y’ && (is_category() || is_archive() || is_home())) return TRUE;
else if (isset($booShortCode) && $booShortCode == TRUE) return TRUE;
else return FALSE;

}

ok, i think we’re all good on the excerpts too… The plugin does it’s thing to the excerpt before the theme gets the excerpt, so any theme that plays with the excerpt can mess up or remove the buttons. In this case my theme was doing that, and i’ve fixed it.

Looking forward to a new version of ssba with these fixes (hopefully they will work for you in a thorough testing) …

Thanks for looking at this.

— shanna

P.S. – I am finding it impossible to tell the difference between using categories/archives and using excerpts, as they seem to do the same thing – both adding buttons to the excerpts. This is also the case with the front page (but not home page, obviously). What i would have expected is that excerpts and categories/archives would operate independently, with excerpts adding buttons to individual excerpts and categories/archives adding one set up buttons for the whole page. Right now excerpts doesn’t even seem to work unless categories/archives is also enabled. So i think there is definitely some confusion here in what functionality to expect for the applicable page-type settings. I found that it’s easy enough to make excerpts work independently by adding ssba_excerpts to the check in show_share_buttons, and to the check i added called ssba_are_buttons_required. With that the excerpts will show without enabling categories/archives, but categories/archives still won’t display one set of buttons for the whole page, nor does the home page when it’s a front page. Maybe i’ll play with this a bit more later.

To modify this plugin so that it only adds scripts and style when buttons are actually used on a page, make the following changes to inc/ssba_styles.php

1. Create a new function to check whether buttons are actually used.

// check if this page requires buttons
function ssba_are_buttons_required($arrSettings) {

if (isset($arrSettings[‘ssba_pages’]) && $arrSettings[‘ssba_pages’] == ‘Y’ && is_page()) return TRUE;
else if (isset($arrSettings[‘ssba_posts’]) && $arrSettings[‘ssba_posts’] == ‘Y’ && is_single()) return TRUE;
else if (isset($arrSettings[‘ssba_cats_archs’]) && $arrSettings[‘ssba_cats_archs’] == ‘Y’ && is_category()) return TRUE;
else if (isset($arrSettings[‘ssba_cats_archs’]) && $arrSettings[‘ssba_cats_archs’] == ‘Y’ && is_archive()) return TRUE;
else if (isset($arrSettings[‘ssba_homepage’]) && $arrSettings[‘ssba_homepage’] == ‘Y’ && is_home()) return TRUE;
else if (isset($arrSettings[‘ssba_homepage’]) && $arrSettings[‘ssba_homepage’] == ‘Y’ && is_front_page()) return TRUE;
else if (isset($booShortCode) && $booShortCode == TRUE) return TRUE;
else return FALSE;

}

2. Call the new function near the top of ssba_page_scripts :

function ssba_page_scripts() {

// get settings
$arrSettings = get_ssba_settings();

// are buttons needed for this page?
if (!ssba_are_buttons_required($arrSettings)) return;

…

}

3. Call the new function near the top of get_ssba_style :

function get_ssba_style() {

// query the db for current ssba settings
$arrSettings = get_ssba_settings();

// are buttons needed for this page?
if (!ssba_are_buttons_required($arrSettings)) return;

…

}

Hope this works for you. My (somewhat superficial) testing shows that it eliminates the unneeded HTTP requests.

— shanna

Hi again. I’ve never used this plugin on excerpts, and i see that it’s not working for me on excerpts. I will look into this. Meanwhile, in the next post is a fix to only add scripts and style when the buttons are actually used on a page.

— shanna