Mark Wilkinson
Forum Replies Created
-
Forum: Plugins
In reply to: [Better Core Video Embeds] WordPress 6.5Yes I have done tests with the plugin on WordPress 6.5 which indicates it works fine as far as I can see.
Forum: Plugins
In reply to: [Better Core Video Embeds] PHP Warning(s) in Errorlog with 1.3.4I am not quite sure why the error occurs. In my testing environment, the
getimagesizes()
function just returnsfalse
for that default YouTube thumbnail and I get no warning logs in the error log.Does the plugin work correctly for valid Youtube videos?
Forum: Plugins
In reply to: [Better Core Video Embeds] PHP Warning(s) in Errorlog with 1.3.4Hi – can you provide a link to a page on your site which triggers this error please?
Forum: Plugins
In reply to: [Better Core Video Embeds] error after updating to 1.3.1Hi there – a new plugin fix has just been released for this – v1.3.2
Forum: Plugins
In reply to: [Better Core Video Embeds] error after updating to 1.3.1Hi there,
I have worked on a fix here:
https://github.com/highrisedigital/better-core-video-embeds/tree/feature/special-chars-fix
Would you be able to download that a ZIP and test on your site please? Deactivate the original first.
Forum: Plugins
In reply to: [Better Core Video Embeds] error after updating to 1.3.1Hi there,
Thanks for reporting this issue – I can see this issue too and I am looking to resolve this asap.
Forum: Plugins
In reply to: [Better Core Video Embeds] Plugin alters extended chars in captionsHi – thanks for confirming that it works. Understood about the characters.
I will push a plugin update shortly.
Forum: Plugins
In reply to: [Better Core Video Embeds] Plugin alters extended chars in captionsHi there and thanks for submitting this issue. I have taken a look at the problem and produced what I think is a fix.
Could you download the following and add to your site to test please? You will need to deactivate the current plugin first of course.
https://github.com/highrisedigital/better-core-video-embeds/tree/feature/special-chars-fix
That download includes a fix and it would be great to see if it works for you before updating the plugin for everyone.
Let me know if you need an assistance with that.
Forum: Plugins
In reply to: [Better Core Video Embeds] Error in LogHi there, great news and thanks for letting me know.
Forum: Plugins
In reply to: [Better Core Video Embeds] Error in LogHi there, I have tried embedding those videos into my test site (I could see three on the page in your error log using BCVE).
In my test env. I get no errors happeing.
It could be from something else on the page. I notice there is another video on the page which appears to be embedded without using BCVE.
Forum: Plugins
In reply to: [Better Core Video Embeds] Play button vertical alignment in SafariHi Jaiji,
I think adding your own CSS for these use-cases is the best way forward. Everyone’s sites are going to be different at the end of the day.
Forum: Plugins
In reply to: [Better Core Video Embeds] Play button vertical alignment in SafariHi Jaiji,
Thanks for reporting the issue.
On Inspection I can see that the current version of Safari is 17.2 and therefore the version you mentioned is very outdated.
Therefore this is not something we are going to fix in the plugin. As you have mentioned yourself, you could offer a fix in your own CSS for this.
Kind regards,
MarkForum: Plugins
In reply to: [Better Core Video Embeds] Thumbnail sizesCould you share the video URLs please? The thumbnails are cached for a day and therefore if you have changed them they may not change straight away.
Forum: Plugins
In reply to: [Better Core Video Embeds] Thumbnail sizesHi Jaiji,
Thanks for using the plugin. Do you have the URL of the page where these videos are not displaying correct please. Maybe I could take a look?
Forum: Plugins
In reply to: [Better Core Video Embeds] AccessibilityHi Patrick,
Thanks for the suggestion and it certainly sounds like a sensible approach to me.
This is something that you could achieve yourself with just a little code. The play button, like the rest of the markup is added using a callback function on the
hd_bcve_video_thumbnail_markup
hook.This means that you could easily unhook the plugins callback that adds the play button.
remove_action( 'hd_bcve_video_thumbnail_markup', 'hd_bcve_add_video_play_button', 20, 4 );
Then you could hook something in which adds your button. For example:
/** * Adds the play button div to the markup. * * @param array $block The block array. * @param string $video_id The ID of the embedded video. * @param string $thumbnail_url The URL of the video thumbnail. * @param array $wrapper_classes An array of CSS classes to add to the wrapper. */ function prefix_add_video_play_button( $block, $video_id, $thumbnail_url, $wrapper_classes ) { ?> <button class="play-button" aria-label="Play Video"></button> <?php } add_action( 'hd_bcve_video_thumbnail_markup', 'prefix_add_video_play_button', 20, 4 );
This would achieve the result you are after and then you could add the following lines of CSS, maybe in the customizer to style it.
.hd-bcve-wrapper .play-button { background-color: transparent; border: none; }
I may well add something like this in the future, but for now the above should achieve the results you are looking for.