Mark Wilkinson

As fix has now been pushed out for this.

@mustardbees thanks for the pull request. I will add this to the plugin and release in the next few days to get this fixed for users.

Hi there,

Unfortunately this plugin is no longer in development and as such not supported.

I would urge you to move to a more modern integration method with Broadbean such as JobRelay.

I can confirm that with Jetpack enabled and the “Compose using shortcodes to embed media from popular sites” module active, Vimeo embeds break.

However, have looked at the explanation of what that module is, it says.

Shortcodes are WordPress-specific markup that let you add media from popular sites. This feature is no longer necessary as the editor now handles media embeds rather gracefully.

Therefore I don’t really see a need for this module to be active, whilst using the Better Core Video Embeds plugin?

Is there a reason you need both active?

Hi Knut,

Did you manage to find any conflicts here? If I can help at all please let me know.

This seems to be working for me. Can you confirm the exact URL you are pasting into the editor please?

I am no GDPR expert at all, but I would think no in this case. This is because the thumbnail images are still being served from the video provider.

I have just released version 1.1.3 of the plugin which adds an empty alt tag to the thumbnail.

Having done some research I think this is best solution for now.

Version 1.1.3 (released just now) of the plugin should correct this issue. I am going to mark this as resolved.

I think you are right and it makes sense to included the non www versions. These were not include originally as copying the address from Youtube always adds the www.

However since the embed works with the www it makes sense to make this work too. I will add this into the next release.

You make a very valid point here however, what should the alt text be for the images? The reason this is difficult is that the oEmbed iFrame that is returned from the oEmbed service doesn’t contain the video title at all.

The only thing we have is the video ID and the video service name (e.g. Youtube). To get the title would require some sort of integration with the Youtube API which I would rather avoid as it gets complicated for users.

I you have any further ideas on what the alt attribute value should be then I would love to hear them please.

Hi there,

Thank you so much for the positive review – I am really pleased that you are finding the plugin useful.

With regards to the additional SEO words, I am always cautious about mentioning that fact the plugin could help with GDPR as it was not built for that purpose and probably doesn’t do a good enough job.

It still has to contact the Youtube servers in order to grab the thumbnail and therefore it is not going to be a complete cookie free solution. Therefore I am wary about suggesting it is so.

That said, it does use the Youtube no cookie domain for the embed and therefore I could certainly think about adding that in the description.

Thanks again for using the plugin and leaving such as a positive review.

Kind regards,
Mark

This should now be fixed with version 1.1 released just now.

Hi Mark,

Thanks for testing – I managed to recreate this. I think it stems from the hook being using to register the style.

I have now amended this and it is working for me in my tests.

Would you be so kind as the test the development branch of the plugin please to make sure this fixes the error?

https://github.com/highrisedigital/better-core-video-embeds/tree/develop

It should also correct the max width CSS issue you mentioned. If it is working for you I can then be more confident in releasing the next version with these fixes.

Thanks in advance.

It is the wp_print_styles function which is used:

https://github.com/WordPress/wordpress-develop/blob/6.1/src/wp-includes/functions.wp-styles.php#L44-L69

I have added the width suggestion to an issue on Github and I will get that out in a bug fix asap.

When you say:

> Also, the modified HTML uses the class name wp-block-image for the replaced embed block: is this intentional?

I assume you mean the <figure> which wraps the thumbnail image from either Youtube or Vimeo?

e.g.

<figure class="wp-block-image hd-bcve-wrapper wp-embed-aspect-16-9 wp-has-aspect-ratio" data-id="ckGngnqN7Z0">

If so that is intentional so it will be styled like an image.