ssl / https
-
Hello,
Looks like this plugin makes a hard link call to an image using https://. This breaks the secure icon for https websites.
Looks like it’s coded into FBC_LOCATION, which is using WP_PLUGIN_URL. Which is the wrong way to do it.
See https://core.trac.www.ads-software.com/ticket/13941
(Basically you’re doing it wrong if you use WP_PLUGIN_URL, and should do it this way: https://codex.www.ads-software.com/Determining_Plugin_and_Content_Directories )
Looks like your other code is modern, just this line is using a 5 year old method.
//define(‘FBC_LOCATION’, WP_PLUGIN_URL . ‘/’.basename(dirname(__FILE__)));
define(‘FBC_LOCATION’, plugin_dir_url(__FILE__));Also, the hard script links get blocked:
https://connect.facebook.net/en_US/all.js#xfbml=1
https://platform.twitter.com/widgets.js
https://assets.pinterest.com/js/pinit.js
Please fix for next version.
- The topic ‘ssl / https’ is closed to new replies.